[BLD-396] Dashboard: Fix changing tabs in /nfts/<id> page shows full page loading indicator #8224
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
WalkthroughAdds a React Suspense boundary around the NFT token page’s tab content with a local fallback loader, moves per-tab rendering inside that Suspense boundary, and adjusts the pending-NFT loading container vertical padding. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant TokenIdPage
participant SuspenseBoundary as Suspense (Tab Area)
participant Fallback as Local Fallback Loader
participant TabContent as Active Tab Renderer
User->>TokenIdPage: navigate / switch tab
TokenIdPage->>SuspenseBoundary: render tab area
alt data / child pending
SuspenseBoundary->>Fallback: show localized spinner + text
else ready
SuspenseBoundary->>TabContent: render active tab content
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8224 +/- ##
=======================================
Coverage 55.02% 55.02%
=======================================
Files 919 919
Lines 60583 60583
Branches 4126 4126
=======================================
Hits 33338 33338
Misses 27141 27141
Partials 104 104
🚀 New features to boost your workflow:
|
MananTank
force-pushed
the
10-09-_bld-396_dashboard_fix_changing_tabs_in__nfts__id_page_showing_full_page_loading_indicator
branch
from
e246d14 to
8dc86dd
Compare
MananTank
changed the title
size-limit report 📦
|
graphite-app
bot
force-pushed
the
graphite-base/8224
branch
from
511aa04 to
fe940b3
Compare
graphite-app
bot
force-pushed
the
10-09-_bld-396_dashboard_fix_changing_tabs_in__nfts__id_page_showing_full_page_loading_indicator
branch
from
8dc86dd to
bcd7141
Compare
graphite-app
bot
force-pushed
the
10-09-_bld-396_dashboard_fix_changing_tabs_in__nfts__id_page_showing_full_page_loading_indicator
branch
from
bcd7141 to
e847c55
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx (1)
61-68: Prefer explicit function declaration with return type.The coding guidelines recommend explicit function declarations and return types for TypeScript. Consider refactoring to:
-export const TokenIdPage: React.FC<TokenIdPageProps> = ({ - contract, - tokenId, - isErc721, - isLoggedIn, - accountAddress, - projectMeta, -}) => { +export function TokenIdPage({ + contract, + tokenId, + isErc721, + isLoggedIn, + accountAddress, + projectMeta, +}: TokenIdPageProps): React.ReactElement {As per coding guidelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
🧠 Learnings (2)
📚 Learning: 2025-06-18T04:27:16.172Z
Learnt from: jnsdls
PR: thirdweb-dev/js#7365
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx:16-17
Timestamp: 2025-06-18T04:27:16.172Z
Learning: Next.js Link component supports external URLs without throwing errors. When used with absolute URLs (like https://...), it behaves like a regular anchor tag without client-side routing, but does not cause runtime crashes or errors as previously believed.
Applied to files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
📚 Learning: 2025-06-18T04:30:04.326Z
Learnt from: jnsdls
PR: thirdweb-dev/js#7365
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx:16-17
Timestamp: 2025-06-18T04:30:04.326Z
Learning: Next.js Link component fully supports both internal and external URLs and works appropriately with all standard anchor attributes including target="_blank", rel="noopener noreferrer", etc. Using Link for external URLs is completely appropriate and recommended.
Applied to files:
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx (3)
5-5: LGTM!The Suspense import is correctly added to support the new loading boundary below.
92-92: Question: Is the vertical padding necessary here?The container already has
h-[400px]withitems-centerfor vertical centering. Addingpy-20seems redundant and may not provide visual benefit since the spinner is already centered. Was this added to match a specific design requirement?
182-201: Verify Suspense usage and optimize active tab rendering.Suspense only works if child components suspend (e.g., via React.lazy or throw promises). Confirm each tab’s
childrenuses a suspense-aware pattern; otherwise the fallback spinner will never display.Replace the
tabs.mapblock with a single lookup:- <Suspense fallback={...}> - {tabs.map(tb => - tb.title === tab && ( - <div className="w-full" key={tb.title}> - {tb.children} - </div> - ) - )} - </Suspense> + <Suspense fallback={...}> + {(() => { + const active = tabs.find(tb => tb.title === tab); + return active ? ( + <div className="w-full" key={active.title}> + {active.children} + </div> + ) : null; + })()} + </Suspense>
Merge activity
|
…page loading indicator (#8224) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `TokenIdPage` component by introducing `Suspense` for improved loading state handling and adjusting the layout of the loading spinner. ### Detailed summary - Added `Suspense` for handling loading states. - Updated the loading spinner layout with additional padding (`py-20`). - Wrapped the tab rendering logic within the `Suspense` component for better user experience during data fetching. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a loading experience for NFT tab content using Suspense, providing a fallback UI while content loads. - Improves responsiveness when switching tabs by deferring heavy content until ready. - Style - Increased vertical padding for the pending NFT state to enhance visual spacing and readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
10-09-_bld-396_dashboard_fix_changing_tabs_in__nfts__id_page_showing_full_page_loading_indicator
branch
from
e847c55 to
edf3aad
Compare
graphite-app
bot
deleted the
10-09-_bld-396_dashboard_fix_changing_tabs_in__nfts__id_page_showing_full_page_loading_indicator
branch
PR-Codex overview
This PR enhances the
TokenIdPagecomponent by integratingSuspensefor loading states and adjusting the layout for better user experience during data fetching.Detailed summary
Suspenseto handle loading states more effectively.py-20).Suspense, providing a fallback UI while loading.Summary by CodeRabbit
New Features
Style