-
Notifications
You must be signed in to change notification settings - Fork 617
Version Packages #8040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8040
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughVersion bumps and changelog updates for nebula, thirdweb, and wagmi-adapter packages, plus deletion or trimming of three changeset files. No source code, API, or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (9)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing touches🧪 Generate unit tests
Comment |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (1)
3-8: Polish wording and brand capitalization (“MetaMask”), and avoid repetition.Recommend tightening the phrasing and capitalizing the brand name for consistency with common usage.
Apply this diff:
- - [#8039](https://github.com/thirdweb-dev/js/pull/8039) [`dc1f7ab`](https://github.com/thirdweb-dev/js/commit/dc1f7ab2ee820be512776a413f7de362ff6b98ef) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Support fully disconnecting from metamask on disconnect + - [#8039](https://github.com/thirdweb-dev/js/pull/8039) [`dc1f7ab`](https://github.com/thirdweb-dev/js/commit/dc1f7ab2ee820be512776a413f7de362ff6b98ef) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Support fully disconnecting MetaMask when disconnectingOptional: if this affects autoconnect behavior or cached provider state, add a short note to set expectations.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog: add brief note under 0.2.142 (optional)Header matches package.json (0.2.142); consider adding a one-liner so the section isn't empty.
## 0.2.142 + +### Patch Changes + +- Internal: version bump only; no code changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/petite-lizards-create.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/petite-lizards-create.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/nebula/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/wagmi-adapter/package.json (1)
58-58: Version bump to 0.2.142 — LGTMPeer range "thirdweb": "^5.85.0" already covers 5.105.45; no action needed.
packages/nebula/package.json (1)
60-60: Version bump to 0.2.45 — LGTMMatches the dependency update to thirdweb via workspace:*; no other changes.
packages/nebula/CHANGELOG.md (1)
3-9: LGTM: nebula 0.2.45 entry correctly documents dependency bump to [email protected].
| }, | ||
| "typings": "./dist/types/exports/thirdweb.d.ts", | ||
| "version": "5.105.44" | ||
| "version": "5.105.45" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump to 5.105.45 — looks good
Release metadata only; no API surface touched.
To align with the guideline to track bundle budgets via package.json#size-limit, please confirm that a size-limit config exists for each changed package.
🏁 Script executed:
#!/bin/bash
# Verify presence of "size-limit" config in changed packages
for f in packages/thirdweb/package.json packages/nebula/package.json packages/wagmi-adapter/package.json; do
echo "Checking $f"
jq 'has("size-limit")' "$f"
doneLength of output: 140
Do not merge — missing size-limit config in changed packages
Version bump to 5.105.45 — release metadata only; no API surface touched.
Verification: jq 'has("size-limit")' returned false for:
- packages/thirdweb/package.json
- packages/nebula/package.json
- packages/wagmi-adapter/package.json
Add a "size-limit" config to each package.json (or provide a root size-limit config), update the PR, and re-run verification.
🤖 Prompt for AI Agents
packages/thirdweb/package.json around line 420: the PR updated the version but
did not add a "size-limit" config; add a "size-limit" key (array of target
entries or a simple config file reference) to this package.json (and likewise to
packages/nebula/package.json and packages/wagmi-adapter/package.json) or create
a root size-limit configuration and reference it from each package.json, commit
the changes, and re-run the verification so jq 'has("size-limit")' returns true
for all three packages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8040 +/- ##
=======================================
Coverage 56.64% 56.64%
=======================================
Files 904 904
Lines 58755 58755
Branches 4170 4170
=======================================
Hits 33280 33280
Misses 25369 25369
Partials 106 106
🚀 New features to boost your workflow:
|
92cd335 to
df2512e
Compare
df2512e to
4a9fc1c
Compare
4a9fc1c to
9ebac36
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
0b45405,dc1f7ab,ea80610,3ad9f7d]:[email protected]
Patch Changes
#8038
0b45405Thanks @joaquim-verges! - Accept pre signed authorizations for 7702 account transactions#8039
dc1f7abThanks @joaquim-verges! - Support fully disconnecting from metamask on disconnect#8042
ea80610Thanks @joaquim-verges! - Fix signAuthorization implementation for 1193 provider#8041
3ad9f7dThanks @joaquim-verges! - Allow passing overrides to common extension functions@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on version updates for several packages, specifically
thirdweb,nebula, andwagmi-adapter. It includes changes to the version numbers and updates to the changelogs reflecting recent enhancements and bug fixes.Detailed summary
thirdwebversion from5.105.44to5.105.45nebulaversion from0.2.44to0.2.45wagmi-adapterversion from0.2.141to0.2.142thirdwebandnebulawith details on recent changes and fixes.changesetmarkdown filesSummary by CodeRabbit
New Features
Bug Fixes
Chores