Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 9, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@thirdweb-dev/[email protected]

Patch Changes

[email protected]

Patch Changes

@thirdweb-dev/[email protected]


PR-Codex overview

This PR focuses on updating version numbers across multiple packages and adding new entries to the CHANGELOG.md files, indicating recent changes and dependency updates.

Detailed summary

  • Deleted the file .changeset/eighty-taxis-own.md.
  • Updated version in packages/thirdweb/package.json from 5.105.42 to 5.105.43.
  • Updated version in packages/nebula/package.json from 0.2.42 to 0.2.43.
  • Updated version in packages/wagmi-adapter/package.json from 0.2.139 to 0.2.140.
  • Added ## 0.2.43 and dependency update details in packages/nebula/CHANGELOG.md.
  • Added ## 5.105.43 and new feature details in packages/thirdweb/CHANGELOG.md.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation

    • Updated changelogs: Nebula 0.2.43, thirdweb 5.105.43 (notes SignAuthorization support in 1193 provider), wagmi-adapter 0.2.140.
  • Chores

    • Bumped package versions: Nebula to 0.2.43, thirdweb to 5.105.43, wagmi-adapter to 0.2.140.
    • Removed an obsolete changeset file.

No functional changes or user-facing behavior updates included in this release.

@joaquim-verges joaquim-verges requested review from a team as code owners September 9, 2025 23:15
@vercel
Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Sep 9, 2025 11:54pm
nebula Ready Ready Preview Comment Sep 9, 2025 11:54pm
thirdweb_playground Ready Ready Preview Comment Sep 9, 2025 11:54pm
thirdweb-www Ready Ready Preview Comment Sep 9, 2025 11:54pm
wallet-ui Ready Ready Preview Comment Sep 9, 2025 11:54pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Walkthrough

This PR removes a changeset file and updates package versions and changelogs across nebula, thirdweb, and wagmi-adapter. No source code or public API changes are included.

Changes

Cohort / File(s) Summary of changes
Changeset cleanup
.changeset/eighty-taxis-own.md
Deleted the changeset file that previously described a patch for thirdweb signAuthorization support.
Version bumps
packages/nebula/package.json, packages/thirdweb/package.json, packages/wagmi-adapter/package.json
Patch version increments: nebula 0.2.42 → 0.2.43, thirdweb 5.105.42 → 5.105.43, wagmi-adapter 0.2.139 → 0.2.140.
Changelog updates
packages/nebula/CHANGELOG.md, packages/thirdweb/CHANGELOG.md, packages/wagmi-adapter/CHANGELOG.md
Added new entries reflecting the version bumps; thirdweb notes signAuthorization support in 1193 provider.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

packages, SDK

Pre-merge checks (1 passed, 1 warning, 1 inconclusive)

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description consists only of autogenerated release notes and the PR-Codex overview and omits the required template sections—namely the commented “## title…” header, “## Notes for the reviewer”, and “## How to test” headings—so it does not adhere to the repository’s description template. Update the PR description to include the hidden comment block from the repository template: add the “## title your PR with this format…” section with the formatted title, then sections for “## Notes for the reviewer” and “## How to test”, even if some fields can temporarily note “N/A” until manual review.
Title Check ❓ Inconclusive The current title “Version Packages” is overly generic and does not clearly convey the primary change or follow the repository’s prescribed “[SDK/Dashboard/Portal] Feature/Fix: …” format; while it hints at version bumps, it lacks sufficient specificity and context for reviewers scanning the history. Please revise the title to a concise, single-sentence summary of the main change that follows the template “[SDK/Dashboard/Portal] Feature/Fix: …”, for example “[SDK] Fix: Bump thirdweb, nebula, and wagmi-adapter patch versions”.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch changeset-release/main

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
packages/thirdweb/CHANGELOG.md (1)

3-8: Nit: code-format the function and consider EIP hyphenation

For consistency with surrounding changelog entries that format identifiers as code, wrap signAuthorization in backticks. Also consider “EIP-1193 provider” for clarity (optional; prior lines mix styles).

- - [#8029](https://github.com/thirdweb-dev/js/pull/8029) [`1759112`](https://github.com/thirdweb-dev/js/commit/1759112d722e11d2d9a902f2221e70636188015e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Add signAuthorization support to 1193 provider
+ - [#8029](https://github.com/thirdweb-dev/js/pull/8029) [`1759112`](https://github.com/thirdweb-dev/js/commit/1759112d722e11d2d9a902f2221e70636188015e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Add `signAuthorization` support to EIP-1193 provider
packages/thirdweb/package.json (1)

420-420: Add a size-limit section with bundle budgets to packages/thirdweb/package.json
No size-limit config exists at the root or in any package—defining local budgets here will enforce size limits for this package.

packages/nebula/package.json (1)

60-60: Optionally add/confirm size-limit budgets.

If nebula is published as a bundle, consider adding a "size-limit" config here or confirm it’s enforced centrally.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1759112 and 9168a65.

📒 Files selected for processing (7)
  • .changeset/eighty-taxis-own.md (0 hunks)
  • packages/nebula/CHANGELOG.md (1 hunks)
  • packages/nebula/package.json (1 hunks)
  • packages/thirdweb/CHANGELOG.md (1 hunks)
  • packages/thirdweb/package.json (1 hunks)
  • packages/wagmi-adapter/CHANGELOG.md (1 hunks)
  • packages/wagmi-adapter/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/eighty-taxis-own.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**

📄 CodeRabbit inference engine (CLAUDE.md)

Wagmi ecosystem integration is in packages/wagmi-adapter/

Files:

  • packages/wagmi-adapter/package.json
  • packages/wagmi-adapter/CHANGELOG.md
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Track bundle budgets via package.json#size-limit

Files:

  • packages/wagmi-adapter/package.json
  • packages/nebula/package.json
  • packages/thirdweb/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`

Applied to files:

  • packages/wagmi-adapter/package.json
  • packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/nebula/CHANGELOG.md (1)

3-9: Changelog entry LGTM

Entry for 0.2.43 correctly documents the dependency bump to [email protected] and links the commit. No action needed.

packages/wagmi-adapter/package.json (1)

58-58: Version bump LGTM

0.2.140 matches the release PR. Nothing else changed.

packages/thirdweb/package.json (1)

420-420: Version bump looks good.

Matches the PR intent and related changelog entry. No other changes observed.

packages/wagmi-adapter/CHANGELOG.md (2)

3-4: Changelog entry added—OK.

Entry for 0.2.140 is present and consistent with prior empty entries style.


3-4: Version sync verified – packages/wagmi-adapter/package.json is at 0.2.140 matching the CHANGELOG.md.

packages/nebula/package.json (1)

60-60: Nebula version bump is fine.

No other fields changed; aligns with changelog note about depending on [email protected].

"types": "./dist/types/exports/thirdweb.d.ts",
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "0.2.139"
"version": "0.2.140"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Quick checks: peer range and bundle budget

  • Peer dep on thirdweb is "^5.85.0" which covers 5.105.43; confirm this is intentional and we don’t need to raise the floor.
  • Per guidelines, ensure size-limit budgeting is tracked for this package (either here or centrally).

Run:


🏁 Script executed:

#!/bin/bash
# 1) Show peer range and latest published thirdweb in lock/workspace
jq -r '.peerDependencies.thirdweb, .devDependencies.thirdweb // empty' packages/wagmi-adapter/package.json

# 2) Check for size-limit config at package or repo root
echo "Has size-limit in wagmi-adapter?" && jq 'has("size-limit")' packages/wagmi-adapter/package.json
echo "Has size-limit in repo root?" && jq 'has("size-limit")' package.json

Length of output: 93


Ensure peerDependency floor and add size-limit budget

  • Confirm that "thirdweb": "^5.85.0" intentionally covers v5.105.43 without raising the minimum.
  • Add a size-limit configuration to packages/wagmi-adapter/package.json (or centrally in the root) to track this package’s bundle budget.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.96 KB (0%) 1.3 s (0%) 336 ms (+103.07% 🔺) 1.7 s
thirdweb (cjs) 356.86 KB (0%) 7.2 s (0%) 1.3 s (+1.39% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 124 ms (+1282.69% 🔺) 239 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 92 ms (+2640% 🔺) 102 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 104 ms (+316.07% 🔺) 487 ms

@joaquim-verges joaquim-verges merged commit 2eaff98 into main Sep 9, 2025
18 of 22 checks passed
@joaquim-verges joaquim-verges deleted the changeset-release/main branch September 9, 2025 23:22
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.63%. Comparing base (1759112) to head (9168a65).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8030      +/-   ##
==========================================
+ Coverage   56.62%   56.63%   +0.01%     
==========================================
  Files         904      904              
  Lines       58685    58685              
  Branches     4162     4166       +4     
==========================================
+ Hits        33229    33238       +9     
+ Misses      25351    25341      -10     
- Partials      105      106       +1     
Flag Coverage Δ
packages 56.63% <ø> (+0.01%) ⬆️
see 4 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants