-
Notifications
You must be signed in to change notification settings - Fork 618
Version Packages #8030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR removes a changeset file and updates package versions and changelogs across nebula, thirdweb, and wagmi-adapter. No source code or public API changes are included. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing Touches🧪 Generate unit tests
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/thirdweb/CHANGELOG.md (1)
3-8: Nit: code-format the function and consider EIP hyphenationFor consistency with surrounding changelog entries that format identifiers as code, wrap signAuthorization in backticks. Also consider “EIP-1193 provider” for clarity (optional; prior lines mix styles).
- - [#8029](https://github.com/thirdweb-dev/js/pull/8029) [`1759112`](https://github.com/thirdweb-dev/js/commit/1759112d722e11d2d9a902f2221e70636188015e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Add signAuthorization support to 1193 provider + - [#8029](https://github.com/thirdweb-dev/js/pull/8029) [`1759112`](https://github.com/thirdweb-dev/js/commit/1759112d722e11d2d9a902f2221e70636188015e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Add `signAuthorization` support to EIP-1193 providerpackages/thirdweb/package.json (1)
420-420: Add asize-limitsection with bundle budgets to packages/thirdweb/package.json
Nosize-limitconfig exists at the root or in any package—defining local budgets here will enforce size limits for this package.packages/nebula/package.json (1)
60-60: Optionally add/confirm size-limit budgets.If nebula is published as a bundle, consider adding a "size-limit" config here or confirm it’s enforced centrally.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/eighty-taxis-own.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/eighty-taxis-own.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/wagmi-adapter/package.jsonpackages/nebula/package.jsonpackages/thirdweb/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry LGTMEntry for 0.2.43 correctly documents the dependency bump to [email protected] and links the commit. No action needed.
packages/wagmi-adapter/package.json (1)
58-58: Version bump LGTM0.2.140 matches the release PR. Nothing else changed.
packages/thirdweb/package.json (1)
420-420: Version bump looks good.Matches the PR intent and related changelog entry. No other changes observed.
packages/wagmi-adapter/CHANGELOG.md (2)
3-4: Changelog entry added—OK.Entry for 0.2.140 is present and consistent with prior empty entries style.
3-4: Version sync verified – packages/wagmi-adapter/package.json is at 0.2.140 matching the CHANGELOG.md.packages/nebula/package.json (1)
60-60: Nebula version bump is fine.No other fields changed; aligns with changelog note about depending on [email protected].
| "types": "./dist/types/exports/thirdweb.d.ts", | ||
| "typings": "./dist/types/exports/thirdweb.d.ts", | ||
| "version": "0.2.139" | ||
| "version": "0.2.140" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Quick checks: peer range and bundle budget
- Peer dep on thirdweb is "^5.85.0" which covers 5.105.43; confirm this is intentional and we don’t need to raise the floor.
- Per guidelines, ensure size-limit budgeting is tracked for this package (either here or centrally).
Run:
🏁 Script executed:
#!/bin/bash
# 1) Show peer range and latest published thirdweb in lock/workspace
jq -r '.peerDependencies.thirdweb, .devDependencies.thirdweb // empty' packages/wagmi-adapter/package.json
# 2) Check for size-limit config at package or repo root
echo "Has size-limit in wagmi-adapter?" && jq 'has("size-limit")' packages/wagmi-adapter/package.json
echo "Has size-limit in repo root?" && jq 'has("size-limit")' package.jsonLength of output: 93
Ensure peerDependency floor and add size-limit budget
- Confirm that
"thirdweb": "^5.85.0"intentionally covers v5.105.43 without raising the minimum. - Add a
size-limitconfiguration topackages/wagmi-adapter/package.json(or centrally in the root) to track this package’s bundle budget.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8030 +/- ##
==========================================
+ Coverage 56.62% 56.63% +0.01%
==========================================
Files 904 904
Lines 58685 58685
Branches 4162 4166 +4
==========================================
+ Hits 33229 33238 +9
+ Misses 25351 25341 -10
- Partials 105 106 +1
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
1759112]:[email protected]
Patch Changes
1759112Thanks @joaquim-verges! - Add signAuthorization support to 1193 provider@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers across multiple packages and adding new entries to the
CHANGELOG.mdfiles, indicating recent changes and dependency updates.Detailed summary
.changeset/eighty-taxis-own.md.versioninpackages/thirdweb/package.jsonfrom5.105.42to5.105.43.versioninpackages/nebula/package.jsonfrom0.2.42to0.2.43.versioninpackages/wagmi-adapter/package.jsonfrom0.2.139to0.2.140.## 0.2.43and dependency update details inpackages/nebula/CHANGELOG.md.## 5.105.43and new feature details inpackages/thirdweb/CHANGELOG.md.Summary by CodeRabbit
Documentation
Chores
No functional changes or user-facing behavior updates included in this release.