-
Notifications
You must be signed in to change notification settings - Fork 619
packages/ui: Add breadcrumb, tooltip, table #7926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages/ui: Add breadcrumb, tooltip, table #7926
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
aa3340e to
cd8d19e
Compare
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7926 +/- ##
==========================================
- Coverage 56.54% 56.53% -0.01%
==========================================
Files 904 904
Lines 58592 58592
Branches 4140 4143 +3
==========================================
- Hits 33131 33126 -5
- Misses 25355 25360 +5
Partials 106 106
🚀 New features to boost your workflow:
|
cd8d19e to
2ce51c5
Compare
2ce51c5 to
4f4faa5
Compare
551d6e9 to
022e1e7
Compare
1d1861f to
085d119
Compare
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on adding the `@radix-ui/react-tooltip` package and refactoring the tooltip and breadcrumb components across multiple applications to enhance UI functionality and maintainability.
### Detailed summary
- Added `@radix-ui/react-tooltip` dependency in `package.json`.
- Updated `knip.json` files to include `@radix-ui/react-tooltip` in ignored dependencies.
- Refactored tooltip components in `packages/ui/src/components/tooltip.tsx` to utilize `@radix-ui/react-tooltip`.
- Created new `Breadcrumb` components in `packages/ui/src/components/breadcrumb.tsx`.
- Updated table components in `packages/ui/src/components/table.tsx` to streamline exports and structure.
- Removed redundant tooltip component definitions from multiple applications and replaced them with imports from `@workspace/ui/components/tooltip`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
085d119 to
55a4728
Compare
022e1e7 to
e20b1dd
Compare

PR-Codex overview
This PR introduces the
@radix-ui/react-tooltiplibrary to various components, enhances theTooltipimplementation, and modifies theBreadcrumbandTablecomponents. It also updates configuration files to include new dependencies and adjust ignored paths.Detailed summary
@radix-ui/react-tooltipdependency topackage.json.knip.jsonfiles to ignore@radix-ui/react-tooltip.Tooltipcomponent inpackages/ui/src/components/tooltip.tsx.TooltipLabelfunction to utilize the newTooltipcomponent.Breadcrumbcomponent inpackages/ui/src/components/breadcrumb.tsx.Tablecomponent inpackages/ui/src/components/table.tsxto include new structure and imports.Tooltipimplementations fromapps/portal/src/components/ui/tooltip.tsxandapps/playground-web/src/components/ui/tooltip.tsx.