Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Aug 27, 2025


PR-Codex overview

This PR focuses on refactoring the ScrollShadow component by removing its local CSS module and consolidating its functionality. It also updates various imports across the application to use the new centralized ScrollShadow component.

Detailed summary

  • Deleted multiple ScrollShadow files and CSS modules from various apps.
  • Introduced a new ScrollShadow component in packages/ui/src/components/scroll-shadow.tsx.
  • Updated imports for ScrollShadow across several components to point to the new centralized location.
  • Refactored the ScrollShadow component to use inline styles instead of CSS classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Aug 27, 2025 11:27pm
thirdweb_playground Ready Ready Preview Comment Aug 27, 2025 11:27pm
thirdweb-www Ready Ready Preview Comment Aug 27, 2025 11:27pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Aug 27, 2025 11:27pm
wallet-ui Skipped Skipped Aug 27, 2025 11:27pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui August 27, 2025 12:24 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula August 27, 2025 12:24 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: c5ef55e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 08-27-packages_ui_add_scroll-shadow.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages labels Aug 27, 2025
@MananTank MananTank marked this pull request as ready for review August 27, 2025 12:25
@MananTank MananTank requested review from a team as code owners August 27, 2025 12:25
Copy link
Member Author

MananTank commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title packages/ui: Add scroll-shadow.tsx packages/ui: Add scroll-shadow Aug 27, 2025
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.54%. Comparing base (afd1150) to head (c5ef55e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7924   +/-   ##
=======================================
  Coverage   56.54%   56.54%           
=======================================
  Files         904      904           
  Lines       58592    58592           
  Branches     4140     4140           
=======================================
  Hits        33131    33131           
  Misses      25355    25355           
  Partials      106      106           
Flag Coverage Δ
packages 56.54% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.06 KB (0%) 1.3 s (0%) 376 ms (+46.72% 🔺) 1.7 s
thirdweb (cjs) 357.05 KB (0%) 7.2 s (0%) 1.9 s (+4.4% 🔺) 9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 73 ms (+305.83% 🔺) 188 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 80 ms (+828.58% 🔺) 90 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 111 ms (+215.9% 🔺) 494 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 27, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `ScrollShadow` component by consolidating its usage across various applications and removing redundant files. It also enhances the component's styling and functionality.

### Detailed summary
- Deleted multiple `ScrollShadow` component files from various apps.
- Created a new `ScrollShadow` component in `packages/ui/src/components/scroll-shadow.tsx`.
- Updated import paths for `ScrollShadow` in multiple files across the applications.
- Simplified styling by removing CSS module imports and integrating styles directly within the component.
- Added new CSS properties for shadows as inline styles.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 08-27-packages_ui_add_storybook branch from 56a4ba2 to afd1150 Compare August 27, 2025 23:18
@graphite-app graphite-app bot force-pushed the 08-27-packages_ui_add_scroll-shadow.tsx branch from 065d050 to c5ef55e Compare August 27, 2025 23:19
@vercel vercel bot temporarily deployed to Preview – nebula August 27, 2025 23:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 27, 2025 23:19 Inactive
Base automatically changed from 08-27-packages_ui_add_storybook to main August 27, 2025 23:27
@graphite-app graphite-app bot merged commit c5ef55e into main Aug 27, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 08-27-packages_ui_add_scroll-shadow.tsx branch August 27, 2025 23:28
@vercel vercel bot temporarily deployed to Production – nebula August 27, 2025 23:28 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui August 27, 2025 23:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground August 27, 2025 23:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www August 27, 2025 23:42 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 August 27, 2025 23:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants