Add chinese locale to connect button #7807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yashjoisar <[email protected]>
🦋 Changeset detectedLatest commit: 4f16cb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughSupport for Simplified Chinese ("zh_CN") localization was added across multiple wallet-related UI modules, including ConnectWallet, injected wallets, in-app wallets, and smart wallets. This involved extending locale type definitions, updating locale retrieval functions to support dynamic imports for Changes
Sequence Diagram(s)sequenceDiagram
participant UI as Wallet UI Component
participant LocaleGetter as getLocale function
participant LocaleModule as zh.ts
UI->>LocaleGetter: getLocale("zh_CN")
LocaleGetter->>LocaleModule: import zh.ts
LocaleModule-->>LocaleGetter: locale object
LocaleGetter-->>UI: locale object
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Yash094
added
the
DO NOT MERGE
Contributor
size-limit report 📦
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7807 +/- ##
==========================================
- Coverage 56.33% 56.31% -0.02%
==========================================
Files 905 905
Lines 58806 58830 +24
Branches 4145 4150 +5
==========================================
+ Hits 33130 33132 +2
- Misses 25571 25592 +21
- Partials 105 106 +1
🚀 New features to boost your workflow:
|
Yash094
removed
the
DO NOT MERGE
Co-authored-by: yashjoisar <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -0,0 +1,13 @@ | |||
| import type { SmartWalletLocale } from "./types.js"; | |||
|
|
|||
| const smartWalletLocalZh: SmartWalletLocale = { | |||
Contributor
There was a problem hiding this comment.
There's a typo in the variable name smartWalletLocalZh. It should be smartWalletLocaleZh to maintain consistency with the naming convention used in other locale files.
Suggested change
| const smartWalletLocalZh: SmartWalletLocale = { | |
| const smartWalletLocaleZh: SmartWalletLocale = { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Co-authored-by: yashjoisar <[email protected]>
github-actions
bot
added
the
Playground
joaquim-verges
deleted the
cursor/add-chinese-locale-to-connect-button-1320
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SDK] Feature: Add Chinese (Simplified) locale for ConnectButton
Notes for the reviewer
zh_CNlocale support for theConnectButtoncomponent.How to test
localeprop on theConnectButtoncomponent to"zh_CN".PR-Codex overview
This PR introduces support for the Chinese locale (
zh_CN) across multiple components in thethirdwebpackages, enhancing the application's accessibility for Chinese-speaking users.Detailed summary
zh_CNentry to the locale list intypes.ts.LocaleFormControlto include Chinese as an option.zh_CNcases in various files.SmartWallet,InjectedWallet, andInAppWallet.Summary by CodeRabbit
New Features
Chores