Skip to content

Revert "fix: Preserve fullscreen mode for embedded content in WebView" #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "fix: Preserve fullscreen mode for embedded content in WebView" #819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions course/src/main/java/in/testpress/course/fragments/WebViewVideoFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.webkit.CookieManager
import android.webkit.WebView
import android.widget.ProgressBar
import androidx.lifecycle.Observer
Expand Down Expand Up @@ -83,17 +82,11 @@ open class WebViewVideoFragment : BaseVideoWidgetFragment() {
webView.scrollBarStyle = WebView.SCROLLBARS_OUTSIDE_OVERLAY
webView.setOnLongClickListener { true }
webView.isLongClickable = false
// Enable third-party cookies for embedded code content
CookieManager.getInstance().setAcceptThirdPartyCookies(webView, true)
}

open fun loadVideo(content: DomainContent) {
val html = if (video?.embedCode?.contains("class=\"fullscreenContent\"") == true) {
video?.embedCode
} else {
"<div style='margin-top: 15px padding-left: 20px padding-right: 20px'" +
"class='videoWrapper'>" + video?.embedCode + "</div>"
}
val html = "<div style='margin-top: 15px padding-left: 20px padding-right: 20px'" +
"class='videoWrapper'>" + video?.embedCode + "</div>"

webViewUtils.initWebView(html, activity)
webView.webChromeClient = fullScreenChromeClient
Expand Down