-
Couldn't load subscription status.
- Fork 1
Revert "fix: Preserve fullscreen mode for embedded content in WebView" #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Revert "fix: Preserve fullscreen mode for embedded content in WebView" #819
Conversation
WalkthroughThe changes remove the third-party cookie acceptance feature from the WebView in the video fragment. The HTML generation logic for video embedding has been simplified by eliminating conditional checks based on the presence of a "fullscreenContent" class. The code now consistently constructs the HTML wrapper for video embeds without differentiating based on the embed content. No modifications were made to any public or exported entities. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant VF as WebViewVideoFragment
participant WH as WebView
U->>VF: Request to play video
VF->>VF: Construct HTML wrapper for video embed (simplified)
VF->>WH: Load generated HTML
WH-->>U: Render video content
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reverts #818
Summary by CodeRabbit