fix: update suggestion pane when clicking in preview pane #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update the suggestion pane when clicking elements in the preview pane.
Why:
PR #264 changed some things to prevent sandbox updates while selecting inputs so users can type in them. But at the same time, it broke direct updates of the suggestion pane.
How:
The
ON_SELECT_NODEevent now also triggers aSANDBOX_READY, which includes the parser result.As the sandbox doesn't really evaluate anything, a
SANDBOX_BUSYis not emitted.Checklist:
fixes: #268