fix: prevent sandbox update when clicking elements in sandbox #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes the issue where selecting an
inputin thesandbox, causes a direct update of that same sandbox. The problem with that is that whatever is being typed in aninput, is directly being undone.Why:
Because not being able to type in inputs, is highly frustrating.
How:
Let the
state reducerknow that it's thesandboxthat caused the update, so that it can skip thesandbox updateeffect.Sandbox only updates the query, in a way that results to the same element selection. So we can skip a round trip, and highlight the element directly from within the sandbox.
Checklist: