Skip to content

fix: correct og:image path in client build #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

fix: correct og:image path in client build #212

merged 3 commits into from
Jun 26, 2020

Conversation

ljosberinn
Copy link
Contributor

What:

hopefully fixes #143 (comment)

How:

rewriting relative paths in meta tags to absolute

@ljosberinn
Copy link
Contributor Author

alright, so this should be working, I'll revert the last commit

before:
image
image

after:
image
image

@ljosberinn ljosberinn marked this pull request as ready for review June 23, 2020 21:18
@smeijer smeijer changed the title fix: attempt fixing tags postbuild fix: correct og:image path in client build Jun 26, 2020
@smeijer smeijer merged commit cd73597 into testing-library:develop Jun 26, 2020
@smeijer
Copy link
Member

smeijer commented Jun 26, 2020

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ljosberinn ljosberinn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljosberinn @smeijer