-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat: improve seo & social media links #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- replace with meta tags
Not a huge issue, but do other sites also have that problem? |
No, only Discord. Inspecting class names was what made me experiment, because..
But we don't use |
To be fair, tweets are something else, but yeah, I'll keep continue digging because I don't see that behaviour on any of my own sites 😅 For reference: https://twitter.com/CoinbitIO/status/1136959919612145664 |
I see 😅 long live standards |
This one shows the title at three places, can it be related? ( |
highly recommended not to use it anyways
Yeah, I assume Discord is using one of those as |
- revert debug meta changes
Can we also leave some elements out? I don't really need to have my name there so prominently visible. Testing Playground is no longer mine. We have a number of contributors now. |
And maybe we should just use the frog instead of that screenshot? What do you think? Nice work by the way! I like where this is going 🙂👍 |
Sure! I just figured there's a reason it was initially added. If the oembed is exclusively crawled when also crawling the site, I'd just drop
I'm on the fence about the frog. Sites will go for |
Oembed is there for iframe.ly and embed.ly. I'm not sure about what they need. So maybe we should just accept that discord won't be perfect? About the frog, your image looks better. Maybe we'll optimize that more in the future with an image that scales better. |
I'll try to see how much of the oembed info can be omitted so that embed.ly and iframely are still happy. |
Dropped author meta tag & author info in oembed. When keeping the author tag but dropping the info in oembed, embed.ly will use the author tag as replacement and you wanted it removed anyways. The only occurance of your name is now indirectly through the Discord looks like this now, using Twitter etc. are unchanged. Embed.ly is still happy. But apparently I'm unable to test iframely with a deploy preview? |
Yeah, that's okay :)
Can we make that gray |
- also use jpg, no alpha channel needed to be stored
Thanks for your hard work on this! Much appreciated! |
@all-contributors please add @ljosberinn for code. *edit, Oops. you were already there! I'm new to this. 😇 |
I've put up a pull request to add @ljosberinn! 🎉 |
@ljosberinn, do you know how to populate the thumbnail on twitter? When browsing twitter, I see two versions:
|
I will take a look! |
After investigating for a while, it might just be because the image has a leading slash. Tags itself should be fine. |
fixes #135
Not sure if therobots.txt
will work like that, currently there's none.Didn't work. If meta tags arent fine, I'll try to use redirects.
Went through: