Skip to content

Change dev Docker image to use tensorflow:custom-op as base #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Change dev Docker image to use tensorflow:custom-op as base #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
FROM ubuntu:18.04
FROM tensorflow/tensorflow:custom-op

RUN apt-get update && \
apt-get install -y \
build-essential \
Copy link
Member Author

@BryanCutler BryanCutler Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom-op should set up the required C++ build tools

curl \
nano \
unzip \
ffmpeg

ARG BAZEL_VERSION=0.20.0
ARG BAZEL_VERSION=0.24.1
Copy link
Member Author

@BryanCutler BryanCutler Apr 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongtang I think you said 0.24.1 is preferred to build TF, so updating that here

ARG BAZEL_OS=linux

RUN curl -sL https://github.com/bazelbuild/bazel/releases/download/${BAZEL_VERSION}/bazel-${BAZEL_VERSION}-installer-${BAZEL_OS}-x86_64.sh -o bazel-install.sh && \
Expand Down Expand Up @@ -39,6 +38,7 @@ RUN /bin/bash -c "source activate tfio-dev && python -m pip install \
pytest \
pylint \
boto3 \
google-cloud-pubsub==0.39.1 \
pyarrow==${ARROW_VERSION} \
pandas \
${PIP_ADD_PACKAGES} \
Expand Down