Change dev Docker image to use tensorflow:custom-op as base #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanCutler
commented
Apr 19, 2019
|
|
||
| RUN apt-get update && \ | ||
| apt-get install -y \ | ||
| build-essential \ |
Member
Author
There was a problem hiding this comment.
custom-op should set up the required C++ build tools
BryanCutler
commented
Apr 19, 2019
| ffmpeg | ||
|
|
||
| ARG BAZEL_VERSION=0.20.0 | ||
| ARG BAZEL_VERSION=0.24.1 |
Member
Author
There was a problem hiding this comment.
@yongtang I think you said 0.24.1 is preferred to build TF, so updating that here
Member
Author
|
@yongtang could you please have a look and make sure I'm not missing any required package from the latest ops, thanks! |
yongtang
approved these changes
Apr 21, 2019
Member
yongtang
left a comment
yongtang
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
The bazel 0.24.1 is needed in tensorflow:
tensorflow/tensorflow@407a4f3
We will need google_cloud_cpp as well so preferable to align with 0.24.1.
This was referenced Apr 30, 2019
Merged
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
…base-image Change dev Docker image to use tensorflow:custom-op as base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the tensorflow-io developer Docker file to be based from tensorflow/tensorflow:custom-op. Using this base image gives us Ubuntu 14.04 and gcc 4.8, which is in-line with what TensorFlow is using to allow for better compatibility. The remaining dev image stays the same, installing a newer Bazel version and conda environment with required packages for building/testing.
Fixes #173