Testing some addons image operations #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/addons/pull/398 You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB. |
Member
|
Looks very good @parth-p! Could you add some comment textboxes for each method where you give a very brief description about what the operation is doing? Then I think this is just about ready to merge |
Contributor
Author
|
@seanpmorgan, Sure, I'll do that. |
seanpmorgan
approved these changes
Aug 12, 2019
Member
There was a problem hiding this comment.
LGTM thank you @parth-p! We'll look to make this an updating example notebook as image ops are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples for image operations in addons. Closed previous PR 368.