-
Notifications
You must be signed in to change notification settings - Fork 617
Testing some addons image operations #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/addons/pull/368 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
|
I signed the CLA! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Looking good so far. I think you might want to show the xray picture before the median filter so that folks have a before and after. |
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you click the "x" on the top left of this output to remove the install logging.
Also please use
!pip install tensorflow-gpu==2.0.0-beta1
!pip install tensorflow-addons
TFA should be 0.4
Reply via ReviewNB
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this to say something like "Here is the list of image operations we'll be covering in this example"
Reply via ReviewNB
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to stay away from using anything tensorflow.python as these are private API calls. Could You use PIL instead since it's already imported?
Reply via ReviewNB
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Looking good @parth-p! Few changes requested |
|
One more thing... could you move the file to |
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd support we could use tf.io.read_file directly so that we do not need to access the private API.
Reply via ReviewNB
| @@ -0,0 +1,728 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for this:
- Larger values of flows are better to observe the changes.
- I think
flowsare not necessary to be atf.Variable. Usingtf.convert_to_tensoror even passing numpy array directly is enough in our implementation.
Reply via ReviewNB
Example notebook for all the image operations currently present in the addons repository.