Skip to content

FIX: LazyAdam init #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2019
Merged

FIX: LazyAdam init #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42da012
FIX: update variable name in test
seanpmorgan May 22, 2019
9d301e7
Update optimizer init
seanpmorgan May 22, 2019
b9cc08c
Update params and lint
seanpmorgan May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tensorflow_addons/optimizers/lazy_adam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,23 @@ class LazyAdam(tf.keras.optimizers.Adam):
False.
"""

def __init__(self,
learning_rate=0.001,
beta_1=0.9,
beta_2=0.999,
epsilon=1e-7,
amsgrad=False,
name='LazyAdam',
**kwargs):
super(LazyAdam, self).__init__(
learning_rate=learning_rate,
beta_1=beta_1,
beta_2=beta_2,
epsilon=epsilon,
amsgrad=amsgrad,
name=name,
**kwargs)

def _resource_apply_sparse(self, grad, var, indices):
var_dtype = var.dtype.base_dtype
lr_t = self._decayed_lr(var_dtype)
Expand Down
2 changes: 1 addition & 1 deletion tensorflow_addons/optimizers/lazy_adam_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def doTestBasic(self, use_callable_params=False):
self.evaluate(var0))
self.assertAllCloseAccordingToType(var1_np,
self.evaluate(var1))
self.assertEqual("var0_%d/m:0" % (i,),
self.assertEqual("LazyAdam/var0_%d/m:0" % (i,),
opt.get_slot(var0, "m").name)

@test_utils.run_in_graph_and_eager_modes(reset_test=True)
Expand Down