Skip to content

Conversation

@seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented May 22, 2019

Fixes a break caused by change in upstream:
tensorflow/tensorflow@611db34

@googlebot

This comment has been minimized.

@seanpmorgan
Copy link
Member Author

Only question would be should the name_scope for this optimizer be LazyAdam instead of Adam?

@facaiy facaiy mentioned this pull request May 22, 2019
@facaiy
Copy link
Member

facaiy commented May 22, 2019

I agree, we should override __init__ method to modify the default name .

@seanpmorgan seanpmorgan changed the title FIX: update optimizer variable name in test FIX: LazyAdam init May 22, 2019
Copy link
Member

@facaiy facaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Sean!

@facaiy facaiy merged commit cdacfc1 into tensorflow:master May 22, 2019
@seanpmorgan seanpmorgan deleted the fix-optimizer-test branch June 16, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants