DOC: Update READMEs #255
Merged
DOC: Update READMEs #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindQAQ
requested changes
May 20, 2019
Member
WindQAQ
left a comment
WindQAQ
left a comment
There was a problem hiding this comment.
@seanpmorgan Hi Sean, I drop some comments below. Generally LGTM!
Member
Author
|
Thx for the reviews! Let me know how the changes look |
WindQAQ
previously approved these changes
May 22, 2019
Member
|
Thank you, Sean! @facaiy, feel free to merge this after you take a look :-) |
facaiy
approved these changes
May 22, 2019
Member
facaiy
left a comment
facaiy
left a comment
There was a problem hiding this comment.
Looks great, Sean, Tzu-Wei :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding information since the RFC has been merged. Also adding some instructions for adding examples.
Closes #168