Skip to content

Commit 043b541

Browse files
seanpmorganfacaiy
authored andcommitted
DOC: Update READMEs (#255)
* DOC: Update READMEs * Spelling * Created using Colaboratory * Update READMEs * Minor fix grammar * Add CI testing info * Spelling * Reword * Consistent punctuation * Fix link * Finalize doc updates
1 parent cdacfc1 commit 043b541

File tree

4 files changed

+402
-20
lines changed

4 files changed

+402
-20
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ minor, then feel free to make them without discussion.
1818

1919
Want to contribute but not sure of what? Here are a few suggestions:
2020
1. Add a new example or tutorial. Located in [`examples/`](examples),
21-
these are a great way to familiarize yourself and others with TF-Addons.
21+
these are a great way to familiarize yourself and others with TF-Addons. See
22+
[the guidelines](examples/README.md) for more information on how to add
23+
examples.
2224
2. Solve an [existing issue](https://github.com/tensorflow/addons/issues).
2325
These range from low-level software bugs to higher-level design problems.
2426
Check out the label [help wanted](https://github.com/tensorflow/addons/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22). If you're a new contributor, the label [good first issue](https://github.com/tensorflow/addons/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) can be a good place to start.
@@ -36,11 +38,7 @@ fitting the following criteria:
3638
* The addon is impactful to the community (e.g. an implementation used
3739
in widely cited paper)
3840
* Lastly, the functionality conforms to the contribution guidelines of
39-
its API pattern:
40-
* [Layers](tensorflow_addons/layers/README.md) |
41-
[Optimizers](tensorflow_addons/optimizers/README.md) |
42-
[Losses](tensorflow_addons/losses/README.md) |
43-
[Custom Ops](tensorflow_addons/custom_ops/README.md)
41+
its subpackage.
4442

4543
**Note: New contributions often require team-members to read a research
4644
paper and understand how it fits into the TensorFlow community. This
@@ -56,25 +54,24 @@ It is recommended that development is done in the latest
5654
docker run --rm -it -v ${PWD}:/addons -w /addons tensorflow/tensorflow:nightly-custom-op /bin/bash
5755
```
5856

59-
Try those commands below:
57+
Try these commands below:
6058

61-
0. Format codes automatically: `make code-format`
62-
1. Sanity check: `make sanity-check`
63-
2. Run unit test: `make unit-test`
64-
3. All of the above: `make`
59+
* Format code automatically: `make code-format`
60+
* Run sanity check: `make sanity-check`
61+
* Run unit tests: `make unit-test`
62+
* All of the above: `make`
6563

6664
## Coding style
6765

6866
Addons provides `make code-format` command to format your changes
69-
automatically, don't forget to use it before pushing your codes.
67+
automatically, don't forget to use it before pushing your code.
7068

7169
Please see our [Style Guide](STYLE_GUIDE.md) for more details.
7270

7371
## Code Testing
7472
#### CI Testing
75-
We're in the process of setting up our nightly CI testing. Because this
76-
project will contain CUDA kernels, we need to make sure that the
77-
hardware will be available from our CI provider.
73+
Nighly CI tests are ran and results can be found on the central README. To
74+
subscribe for alerts please join the [addons-testing mailing list](https://groups.google.com/a/tensorflow.org/forum/#!forum/addons-testing).
7875

7976
#### Locally Testing
8077

README.md

Lines changed: 47 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ developments that cannot be integrated into core TensorFlow
3333
| [tfa.image](tensorflow_addons/image/README.md) | SIG-Addons | @windqaq @facaiy |
3434
| [tfa.layers](tensorflow_addons/layers/README.md) | SIG-Addons | @seanpmorgan @facaiy |
3535
| [tfa.losses](tensorflow_addons/losses/README.md) | SIG-Addons | @facaiy @windqaq |
36+
| [tfa.metrics](tensorflow_addons/metrics/README.md) | SIG-Addons | |
3637
| [tfa.optimizers](tensorflow_addons/optimizers/README.md) | SIG-Addons | @facaiy @windqaq |
3738
| [tfa.rnn](tensorflow_addons/rnn/README.md) | Google | @qlzh727 |
3839
| [tfa.seq2seq](tensorflow_addons/seq2seq/README.md) | Google | @qlzh727 |
@@ -45,12 +46,53 @@ User experience and project maintainability are core concepts in
4546
TF-Addons. In order to achieve these we require that our additions
4647
conform to established API patterns seen in core TensorFlow.
4748

49+
#### Proxy Maintainership
50+
Addons has been designed to compartmentalize subpackages and submodules so
51+
that they can be maintained by users who have expertise and a vested interest
52+
in that component.
53+
54+
Subpackage maintainership will only be granted after substantial contribution
55+
has been made in order to limit the number of users with write permission.
56+
Contributions can come in the form of issue closings, bug fixes, documentation,
57+
new code, or optimizing existing code. Submodule maintainership can be granted
58+
with a lower barrier for entry as this will not include write permissions to
59+
the repo.
60+
61+
For more information see [the RFC](https://github.com/tensorflow/community/blob/master/rfcs/20190308-addons-proxy-maintainership.md)
62+
on this topic.
63+
4864
#### Periodic Evaluation of Subpackages
49-
Based on the nature of this repository, there will be contributions that
50-
in time become dated and unused. In order to keep the project
51-
maintainable, SIG-Addons will perform periodic reviews and deprecate
52-
contributions which will be slated for removal. More information will
53-
be available after we submit a formal request for comment.
65+
Given the nature of this repository, subpackages and submodules may become less
66+
and less useful to the community as time goes on. In order to keep the
67+
repository sustainable, we'll be performing bi-annual reviews of our code to
68+
ensure everything still belongs within the repo. Contributing factors to this
69+
review will be:
70+
71+
1. Number of active maintainers
72+
2. Amount of OSS use
73+
3. Amount of issues or bugs attributed to the code
74+
4. If a better solution is now available
75+
76+
Functionality within TensorFlow Addons can be categorized into three groups:
77+
78+
* **Suggested**: well-maintained API; use is encouraged.
79+
* **Discouraged**: a better alternative is available; the API is kept for
80+
historic reasons; or the API requires maintenance and is the waiting period
81+
to be deprecated.
82+
* **Deprecated**: use at your own risk; subject to be deleted.
83+
84+
The status change between these three groups is:
85+
Suggested <-> Discouraged -> Deprecated.
86+
87+
The period between an API being marked as deprecated and being deleted will be
88+
90 days. The rationale being:
89+
90+
1. In the event that TensorFlow Addons releases monthly, there will be 2-3
91+
releases before an API is deleted. The release notes could give user enough
92+
warning.
93+
94+
2. 90 days gives maintainers ample time to fix their code.
95+
5496

5597
## Examples
5698
See [`examples/`](examples/)

examples/README.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# TensorFlow Addons Examples
2+
3+
TensorFlow Addons welcomes and highly encourages example contributions.
4+
5+
6+
## How To Contribute
7+
8+
Addons examples are created using [Google Colab](https://colab.research.google.com/)
9+
and the jupyter notebooks are saved to this directory in the repository. To do
10+
this, follow the below steps:
11+
12+
1. Create a new branch on your fork of TensorFlow Addons
13+
2. Goto [Google Colab](https://colab.research.google.com/) and start a new
14+
notebook using addons example template:
15+
[examples/template.ipynb](template.ipynb)
16+
3. Edit the the links for the "View source on GitHub" and "Run in Google Colab"
17+
URL boxes so that they match the name of your new example notebook
18+
4. Follow the guidelines of the template
19+
5. "Save a copy in Github" and select your new branch. The notebook should be
20+
named `subpackage_submodule`
21+
6. Submit the branch as a PR on the TF-Addons Github

0 commit comments

Comments
 (0)