Skip to content

Conversation

tanzhenyu
Copy link
Contributor

This is from internal design to open-source the DCN network from paper https://arxiv.org/abs/1708.05123

This is from internal design to open-source the DCN network from paper https://arxiv.org/abs/1708.05123
Update commit per Addons format.
@seanpmorgan
Copy link
Member

Majority of issues seem to stem from formatting. Could you please run black ./ or bash tools/run_docker.sh -c 'make code-format'

More indentitation fix.
@tanzhenyu
Copy link
Contributor Author

Majority of issues seem to stem from formatting. Could you please run black ./ or bash tools/run_docker.sh -c 'make code-format'

Done.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more test cases and then LGTM. Thanks for the nice PR!

Added a few more tests.
adding var init.
fix kernel initializer
@tanzhenyu
Copy link
Contributor Author

@seanpmorgan Thanks Sean for the review! Any idea on what the sanity check is doing?
error message - "the remote end hung up unexpectedly; early EOF; index-pack failed; Git fetch failed with exit code: 128"
https://github.com/tensorflow/addons/pull/1018/checks?check_run_id=424954024

@tanzhenyu tanzhenyu requested a review from seanpmorgan February 4, 2020 11:24
@gabrieldemarmiesse
Copy link
Member

I think it's just a connection issue. I'll restart the tests.

@tanzhenyu
Copy link
Contributor Author

I think it's just a connection issue. I'll restart the tests.

Thanks!

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR!

@seanpmorgan seanpmorgan merged commit 3337e98 into tensorflow:master Feb 4, 2020
@tanzhenyu
Copy link
Contributor Author

LGTM thanks for the PR!

Thanks for the review!

@tanzhenyu tanzhenyu deleted the crossing branch February 4, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants