test: fix tests on PHP 7 #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's wrong with the tests this time, as here they are failing when building Docker image... |
AlgebraicWolf
force-pushed
the
fix-tests-php7
branch
from
adc1521 to
b29fb76
Compare
Changes to tests introduced in tarantool-php#89 make them fail on PHP 7.x. This patch fixes failing tests.
AlgebraicWolf
force-pushed
the
fix-tests-php7
branch
from
b29fb76 to
1a68616
Compare
|
Looks like it passes fine now |
|
Hi @AlgebraicWolf, thanks for working on the fix! I decided to go with a simpler version. IMO, we don't need to complicate the tests by asserting core PHP errors, we just need to know that the main error message is expanded with additional info when available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to tests introduced in #89 make them fail on PHP 7.x. This patch fixes failing tests.