errors: more verbose error reporting in StreamConnection
#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rybakit
reviewed
Feb 5, 2024
|
@AlgebraicWolf Thanks for the patch! Please see my comments 👆 |
AlgebraicWolf
force-pushed
the
better-error-reporting
branch
3 times, most recently
from
632dc87 to
76fafdf
Compare
rybakit
reviewed
Feb 6, 2024
This patch makes error reporting in `read` and `send` methods of `StreamConnection` more verbose to provide aid in debugging network errors.
AlgebraicWolf
force-pushed
the
better-error-reporting
branch
from
76fafdf to
576e940
Compare
rybakit
approved these changes
Feb 7, 2024
AlgebraicWolf
added a commit
to AlgebraicWolf/client
that referenced
this pull request
Feb 8, 2024
Changes to tests introduced in tarantool-php#89 make them fail on PHP 7.x. This patch fixes failing tests.
AlgebraicWolf
added a commit
to AlgebraicWolf/client
that referenced
this pull request
Feb 8, 2024
Changes to tests introduced in tarantool-php#89 make them fail on PHP 7.x. This patch fixes failing tests.
Closed
AlgebraicWolf
added a commit
to AlgebraicWolf/client
that referenced
this pull request
Feb 9, 2024
Changes to tests introduced in tarantool-php#89 make them fail on PHP 7.x. This patch fixes failing tests.
AlgebraicWolf
added a commit
to AlgebraicWolf/client
that referenced
this pull request
Feb 9, 2024
Changes to tests introduced in tarantool-php#89 make them fail on PHP 7.x. This patch fixes failing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes error reporting in
readandsendmethods ofStreamConnectionmore verbose to provide aid in debugging network errors.