[Autocomplete] Fix BC and trigger deprecation for EntityAutocompleterInterface
#797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1ed
commented
Apr 16, 2023
1ed
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | - |
| Tickets | Fix #793 |
| License | MIT |
weaverryan
approved these changes
Apr 17, 2023
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Thank you for catching that 👍 - I'll get this merged shortly
Member
|
Thanks Gábor! |
wouterj
reviewed
Apr 18, 2023
|
|
||
| if (null === $groupBy = $autocompleter->getGroupBy()) { | ||
| if (!method_exists($autocompleter, 'getGroupBy')) { | ||
| trigger_deprecation('symfony/ux-autocomplete', '2.8', 'Not implementing the "EntityAutocompleterInterface::getGroupBy()" in "%s" is deprecated.', get_debug_type($autocompleter)); |
Member
There was a problem hiding this comment.
This deprecation is not needed, the @method annotation will already trigger a similar deprecation (which is done via Symfony's DebugClassLoader).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.