bug #797 [Autocomplete] Fix BC and trigger deprecation for EntityAutocompleterInterface (1ed, weaverryan)

This PR was merged into the 2.x branch.

Discussion
----------

[Autocomplete] Fix BC and trigger deprecation for `EntityAutocompleterInterface`

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | -
| Tickets       | Fix #793
| License       | MIT

Commits
-------

4ca03b5 fixing phpcs
f530ac1 [Autocomplete] Fix BC and trigger deprecation for `EntityAutocompleterInterface`

Author: weaverryan

src/Autocomplete/src/AutocompleteResultsExecutor.php

@@ -71,7 +71,9 @@ public function fetchResults(EntityAutocompleterInterface $autocompleter, string
 
         $results = [];
 
-        if (null === $groupBy = $autocompleter->getGroupBy()) {
+        if (!method_exists($autocompleter, 'getGroupBy')) {
+            trigger_deprecation('symfony/ux-autocomplete', '2.8', 'Not implementing the "EntityAutocompleterInterface::getGroupBy()" in "%s" is deprecated.', get_debug_type($autocompleter));
+        } elseif (null === $groupBy = $autocompleter->getGroupBy()) {
             foreach ($paginator as $entity) {
                 $results[] = [
                     'value' => $autocompleter->getValue($entity),

src/Autocomplete/src/EntityAutocompleterInterface.php

@@ -17,6 +17,8 @@
 
 /**
  * Interface for classes that will have an "autocomplete" endpoint exposed.
+ *
+ * @method mixed getGroupBy() Return group_by option.
  */
 interface EntityAutocompleterInterface
 {
@@ -47,8 +49,8 @@ public function getValue(object $entity): mixed;
      */
     public function isGranted(Security $security): bool;
 
-    /**
+    /*
      * Return group_by option.
      */
-    public function getGroupBy(): mixed;
+    /* public function getGroupBy(): mixed; */
 }