Skip to content

Remove forced configuration for tests environment #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Remove forced configuration for tests environment #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions config/packages/test/doctrine.yaml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
Environment variable not found: "APP_SECRET".
-->
Copy link
Member Author

@yceruto yceruto Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO comment feel like a work around when defining environment variables here should be the early way to go. Can be removed or modified?

Copy link
Member

@javiereguiluz javiereguiluz Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Let's do that in a separate PR. Thanks

<env name="APP_SECRET" value="5a79a1c866efef9ca1800f971d689f3e"/>
<env name="DATABASE_URL" value="sqlite:///var/data/blog_test.sqlite"/>
</php>

<testsuites>
Expand Down