Remove forced configuration for tests environment #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Aug 30, 2017
| with data set #0 ('GET', '/en/admin/post/') | ||
| Symfony\Component\DependencyInjection\Exception\EnvNotFoundException: | ||
| Environment variable not found: "APP_SECRET". | ||
| --> |
There was a problem hiding this comment.
This TODO comment feel like a work around when defining environment variables here should be the early way to go. Can be removed or modified?
There was a problem hiding this comment.
Yes! Let's do that in a separate PR. Thanks
javiereguiluz
added a commit
that referenced
this pull request
Aug 30, 2017
This PR was merged into the master branch. Discussion ---------- Remove forced configuration for tests environment We can configure the test database file in `phpunit.xml.dist` and keep it simple. Commits ------- b27b1c6 Remove forced configuration for tests environment
Closed
javiereguiluz
added a commit
that referenced
this pull request
Aug 31, 2017
This PR was merged into the master branch. Discussion ---------- Set environment variables comment for test Fix #627 (comment) Commits ------- abcbe22 Set environment variables comment
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Set environment variables comment for test Fix symfony/demo#627 (comment) Commits ------- abcbe22 Set environment variables comment
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Set environment variables comment for test Fix symfony/demo#627 (comment) Commits ------- abcbe22 Set environment variables comment
frederickboyd
pushed a commit
to frederickboyd/frederickboyd
that referenced
this pull request
May 25, 2025
This PR was merged into the master branch. Discussion ---------- Set environment variables comment for test Fix symfony/demo#627 (comment) Commits ------- abcbe22 Set environment variables comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can configure the test database file in
phpunit.xml.distand keep it simple.