SIL: The inner type of a SILMoveOnlyWrappedType is a lowered position #84771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test Windows |
eeckstein
approved these changes
Oct 9, 2025
| : value(ty.getPointer(), unsigned(category)) { | ||
| if (!ty) return; | ||
| assert(ty->isLegalSILType() && | ||
| ASSERT(ty->isLegalSILType() && |
|
@swift-ci Please test Windows |
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 14, 2025
This PR adopts `Mutex` on all platforms except Darwin (where we still need to back-deploy further than `Mutex` is available.) Blocked by swiftlang/swift#84771. Reapplies #1351. Resolves #538. Resolves rdar://131832797. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't handled properly, as a result specializing a
$@moveOnly Tdid not lower the substitutedT, causing an assertion failure if the substitutedTwas a function type.Fixes rdar://161968922.