Adopt Mutex.
#1351
Merged
Adopt Mutex.
#1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
briancroom,
jerryjrchen and
suzannaratcliff
as code owners
grynspan
added
concurrency
grynspan
force-pushed
the
jgrynspan/538-mutex
branch
from
f31a9b9 to
6e41940
Compare
This PR adopts `Mutex` on all platforms except Darwin (where we still need to back-deploy further than `Mutex` is available.) Resolves #538.
grynspan
force-pushed
the
jgrynspan/538-mutex
branch
from
6e41940 to
39e2c37
Compare
jerryjrchen
reviewed
Oct 3, 2025
grynspan
commented
Oct 3, 2025
| lock.initialize(to: .init()) | ||
| } | ||
| #else | ||
| nonisolated(unsafe) let rawValue = rawValue |
There was a problem hiding this comment.
It's necessary for us to write nonisolated(unsafe) here and a few other places because T isn't universally Sendable. We have some types (pointers) that we need to guard with locks which are not sendable, and the compiler is concerned there may be data races. We know what we're doing (famous last words) but the compiler can't reason about it.
jerryjrchen
approved these changes
Oct 3, 2025
stmontgomery
reviewed
Oct 4, 2025
stmontgomery
approved these changes
Oct 4, 2025
hamishknight
added a commit
to hamishknight/swift-testing
that referenced
this pull request
Oct 4, 2025
This reverts commit 13319e1.
Merged
stmontgomery
pushed a commit
that referenced
this pull request
Oct 4, 2025
Reverts #1351, this is failing to build in CI (https://ci.swift.org/job/oss-swift-pr-test-ubuntu-22_04/9662/)
grynspan
added a commit
that referenced
this pull request
Oct 8, 2025
This PR adopts `Mutex` on all platforms except Darwin (where we still need to back-deploy further than `Mutex` is available.) Resolves #538. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Oct 14, 2025
This PR adopts `Mutex` on all platforms except Darwin (where we still need to back-deploy further than `Mutex` is available.) Blocked by swiftlang/swift#84771. Reapplies #1351. Resolves #538. Resolves rdar://131832797. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts
Mutexon all platforms except Darwin (where we still need to back-deploy further thanMutexis available.)Resolves #538.
Checklist: