Skip to content

[utils] Add message when run-test is run w/o args #8261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2017
Merged

[utils] Add message when run-test is run w/o args #8261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions utils/run-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ def main():
# build_dir.
paths = args.paths
if not paths:
parser.print_usage()
error_exit("error: too few arguments")
Copy link
Contributor

@hughbe hughbe Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is this error even needed anymore now that we show the usage? It seems redundant

Copy link
Member Author

@natecook1000 natecook1000 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but I didn't want to change the output status of the command in case it's being used by something else.

Copy link
Contributor

@dabrahams dabrahams Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well-behaved commands show usage when invalid arguments or --help is passed, and exit with nonzero result when the arguments are invalid.

Copy link
Member Author

@natecook1000 natecook1000 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dabrahams Since this command requires at least one argument, I'm considering no arguments to be invalid. Okay to merge?


if args.build != 'skip':
Expand Down