[utils] Add message when run-test is run w/o args #8261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
hughbe
reviewed
Mar 22, 2017
| paths = args.paths | ||
| if not paths: | ||
| parser.print_usage() | ||
| error_exit("error: too few arguments") |
Contributor
There was a problem hiding this comment.
Nit: is this error even needed anymore now that we show the usage? It seems redundant
Member
Author
There was a problem hiding this comment.
Agreed, but I didn't want to change the output status of the command in case it's being used by something else.
Contributor
There was a problem hiding this comment.
well-behaved commands show usage when invalid arguments or --help is passed, and exit with nonzero result when the arguments are invalid.
Member
Author
There was a problem hiding this comment.
@dabrahams Since this command requires at least one argument, I'm considering no arguments to be invalid. Okay to merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints the usage info if you run
utils/run-testwithout any arguments.$ utils/run-test usage: run-test [-h] [-v] [--build-dir PATH] [--build {true,verbose,skip}] [--target TARGETS] [--mode {optimize_none,optimize,optimize_unchecked,only_executable,only_non_executable}] [--subset {primary,validation,all,only_validation,only_long}] [--param PARAM] [--result-dir PATH] [--lit PATH] [PATH [PATH ...]] run-test: error: too few arguments