[cxx-interop] Allow import-as-member for types in namespaces #82496
+127
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
j-hui
approved these changes
Jun 25, 2025
| : lookup(SerializedSwiftName(nameComponent), | ||
| std::make_pair(ContextKind::TranslationUnit, StringRef())); | ||
| bool entryFound = false; | ||
| for (auto entry : entries) { |
There was a problem hiding this comment.
I tried to refactor that locally, but that means we have to do the casting multiple times, both within the find_if and outside of it. I personally prefer a simple loop here, but I can change it if you feel strongly.
|
@swift-ci please smoke test macOS |
Xazax-hun
approved these changes
Jun 26, 2025
| NamespacesTestSuite.test("Struct in a deep namespace") { | ||
| let s = MyNS.MyDeepNS.DeepNestedStruct() | ||
| expectEqual(456, s.method()) | ||
| expectEqual(456, s.methodConstRef()) |
There was a problem hiding this comment.
If each method added a distinct number to the value we could be 100% sure we end up calling the right method.
There was a problem hiding this comment.
Good idea, let's do that.
This adds support for `swift_name` attribute being used with C++ types that are declared within namespaces, e.g.
```
__attribute__((swift_name("MyNamespace.MyType.my_method()")))
```
Previously import-as-member would only accept a top-level unqualified type name.
rdar://138934888
egorzhdan
force-pushed
the
egorzhdan/allow-qual-swift-name
branch
from
392cdd9 to
e95f6a3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
swift_nameattribute being used with C++ types that are declared within namespaces, e.g.Previously import-as-member would only accept a top-level unqualified type name.
This relies on swiftlang/llvm-project#10899.
rdar://138934888