[Clang][Sema] Allow qualified type names in swift_name attribute
#10899
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
force-pushed
the
egorzhdan/20240723-allow-qual-swift-name
branch
2 times, most recently
from
425f4d4 to
bcb7d65
Compare
|
@swift-ci please test |
j-hui
approved these changes
Jun 25, 2025
clang/lib/Sema/SemaSwift.cpp
Outdated
| // ContextName might be qualified, e.g. 'MyNamespace.MyStruct'. | ||
| SmallVector<StringRef, 1> ContextNameComponents; | ||
| ContextName.split(ContextNameComponents, '.'); | ||
| for (auto Component : ContextNameComponents) { |
There was a problem hiding this comment.
nit: use std::all_of or llvm::all_of here?
egorzhdan
force-pushed
the
egorzhdan/20240723-allow-qual-swift-name
branch
from
bcb7d65 to
a75b134
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
Xazax-hun
approved these changes
Jun 26, 2025
|
|
||
| void nestedStruct_method(MyNS::NestedStruct) SWIFT_NAME("MyNS.NestedStruct.method(self:)"); | ||
| void nestedStruct_methodConstRef(const MyNS::NestedStruct&) SWIFT_NAME("MyNS.NestedStruct.methodConstRef(self:)"); | ||
| void nestedStruct_invalidContext1(MyNS::NestedStruct) SWIFT_NAME(".MyNS.NestedStruct.invalidContext1(self:)"); // expected-warning {{'swift_name' attribute has invalid identifier for the context name}} |
There was a problem hiding this comment.
Maybe we could test double dots (..) as well? Although I do expect that to be rejected as expected.
There was a problem hiding this comment.
Added this test case and a couple more, thanks
This will allow adding `__attribute__((swift_name("MyNamespace.MyType.my_method()")))` on standalone C++ functions to make Swift import them as member functions of a type that is nested in a C++ namespace.
rdar://138934888
egorzhdan
force-pushed
the
egorzhdan/20240723-allow-qual-swift-name
branch
from
a75b134 to
2df5b2b
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will need to go upstream.
This will allow adding
__attribute__((swift_name("MyNamespace.MyType.my_method()")))on standalone C++ functions to make Swift import them as member functions of a type that is nested in a C++ namespace.rdar://138934888