Implement disabling task-local values in isolated deinit #77249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested by the LSG during the proposal review. See https://forums.swift.org/t/accepted-with-modifications-se-0371-isolated-synchronous-deinit/74042
Contributor
|
@swift-ci please smoke test |
ktoso
approved these changes
Oct 30, 2024
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Very clean, thanks for the earlier refactor. LGTM!
So I think we can mark the proposal fully implemented now AFAICS 👍
ktoso
added a commit
to ktoso/swift-evolution
that referenced
this pull request
Oct 30, 2024
With this change swiftlang/swift#77249 it is completely implemented now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by the LSG during the proposal review. See https://forums.swift.org/t/accepted-with-modifications-se-0371-isolated-synchronous-deinit/74042