Mark SE-0371 - isolated deinit implemented in 6.1 #2603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change swiftlang/swift#77249 it is completely implemented now 👍
Contributor
|
Let's wait until swiftlang/swift#76995 is merged. Without it isolated deinit can lead to use-after-free in optimized builds. |
Contributor
|
Also, we still need to update wording of the proposal to accommodate for changes in the task local's behavior request during review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change swiftlang/swift#77249 it is completely implemented now 👍
Note to reviewers: Let me do some additional testing so we don't end up having to revert this.