Skip to content

Fix recent class accessor performance regression #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2017
Merged

Fix recent class accessor performance regression #7485

merged 2 commits into from
Feb 15, 2017

Conversation

@slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Feb 15, 2017

This should fix the performance regression introduced by #6400 by making stored property accessors of Swift-native classes @_transparent again.

When resilience is enabled these accessors are not transparent, so we might need to think of a way to recover the performance some other way eventually.

Fixes rdar://problem/29884727.

@slavapestov
AST: Cache the result of ClassDecl::checkObjCAncestry()
c2d07bc
@slavapestov
AST: Stored property accessors on non-Objective-C derived classes can…
3231655 
… be transparent

In 74d979f, the policy was changed
so that only value type accessors are ever marked transparent, and
not class accessors.

This was intended to fix a bug where inlining an accessor of an
Objective-C-derived class across module boundaries caused a linker
failure because the accessor referenced a field offset variable,
which has hidden visibility.

However, this also caused a performance regression for Swift native
classes. Bring back the old behavior for Swift native classes in
non-resilient modules.

Fixes <rdar://problem/29884727>.
@slavapestov
Copy link
Contributor Author

slavapestov commented Feb 15, 2017

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

slavapestov commented Feb 15, 2017

@swift-ci Please benchmark

@slavapestov
Copy link
Contributor Author

slavapestov commented Feb 15, 2017

@eeckstein Does this look OK for 3.1? The first patch has no functional effect and just speeds up repeated Objective-C ancestry queries -- we don't have to pull it into 3.1.

@swift-ci
Copy link
Contributor

swift-ci commented Feb 15, 2017

Build comment file:

Optimized (O)

Regression (2)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
CaptureProp 3949 4549 +15.2% 0.87x
Calculator 35 38 +8.6% 0.92x
Improvement (2)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
MapReduce 371 341 -8.1% 1.09x
SetExclusiveOr 2638 2361 -10.5% 1.12x
No Changes (168)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
RangeAssignment 305 291 -4.6% 1.05x
DictionaryRemove 2401 2292 -4.5% 1.05x
NSStringConversion 725 700 -3.5% 1.04x
ObjectiveCBridgeFromNSString 1420 1378 -3.0% 1.03x
MapReduceString 74 72 -2.7% 1.03x(?)
ObjectiveCBridgeStubToNSDate 14560 14158 -2.8% 1.03x(?)
StringHasPrefixUnicode 14365 13974 -2.7% 1.03x
StrToInt 5278 5140 -2.6% 1.03x
ObjectiveCBridgeStubFromNSDate 3670 3553 -3.2% 1.03x
ArrayAppendASCII 28289 27705 -2.1% 1.02x
Join 494 484 -2.0% 1.02x
ObjectiveCBridgeToNSSet 38374 37601 -2.0% 1.02x(?)
ArrayAppendOptionals 1240 1217 -1.9% 1.02x(?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 70767 69684 -1.5% 1.02x(?)
ObjectiveCBridgeStubNSDateRefAccess 323 318 -1.6% 1.02x
DeadArray 184 181 -1.6% 1.02x
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 80251 78589 -2.1% 1.02x(?)
ObjectiveCBridgeStubFromArrayOfNSString 60635 59309 -2.2% 1.02x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 158469 156621 -1.2% 1.01x(?)
Array2D 1931 1914 -0.9% 1.01x(?)
ArrayAppendLatin1 50034 49400 -1.3% 1.01x
ObjectiveCBridgeFromNSArrayAnyObjectForced 6082 6051 -0.5% 1.01x(?)
ObjectiveCBridgeFromNSStringForced 2313 2287 -1.1% 1.01x(?)
Prims 755 749 -0.8% 1.01x(?)
ReversedDictionary 93 92 -1.1% 1.01x(?)
ArrayAppendGenericStructs 1230 1223 -0.6% 1.01x(?)
StringInterpolation 9757 9631 -1.3% 1.01x(?)
ObjectiveCBridgeStubToNSString 1516 1507 -0.6% 1.01x(?)
ObjectiveCBridgeStubFromNSStringRef 178 176 -1.1% 1.01x
ObjectiveCBridgeFromNSSetAnyObject 70693 70194 -0.7% 1.01x(?)
ProtocolDispatch2 157 156 -0.6% 1.01x
CharacterLiteralsLarge 12949 12872 -0.6% 1.01x(?)
Dictionary3 538 534 -0.7% 1.01x(?)
Dictionary2 2113 2100 -0.6% 1.01x(?)
ObjectiveCBridgeStubURLAppendPathRef 227461 225762 -0.8% 1.01x(?)
ObjectiveCBridgeToNSArray 32082 31871 -0.7% 1.01x(?)
StringEqualPointerComparison 7314 7274 -0.6% 1.01x(?)
MapReduceSequence 570 565 -0.9% 1.01x(?)
ObjectiveCBridgeStubURLAppendPath 228064 226040 -0.9% 1.01x(?)
SortStringsUnicode 7512 7465 -0.6% 1.01x
171 3008698 2984590 -0.8% 1.01x
ObjectiveCBridgeStubDataAppend 3455 3432 -0.7% 1.01x(?)
NSDictionaryCastToSwift 5446 5393 -1.0% 1.01x(?)
Phonebook 7482 7376 -1.4% 1.01x
ObjectiveCBridgeStubDateAccess 182 181 -0.6% 1.01x
SetExclusiveOr_OfObjects 7431 7364 -0.9% 1.01x(?)
ObjectiveCBridgeToNSDictionary 61486 61134 -0.6% 1.01x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString 99771 98560 -1.2% 1.01x(?)
ObjectiveCBridgeStubNSDataAppend 2286 2266 -0.9% 1.01x(?)
ObjectiveCBridgeStubNSDateMutationRef 12516 12439 -0.6% 1.01x(?)
ArraySubscript 1445 1440 -0.3% 1.00x(?)
DictionarySwapOfObjects 7054 7052 -0.0% 1.00x(?)
StackPromo 23280 23285 +0.0% 1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject 146425 145991 -0.3% 1.00x(?)
Integrate 249 249 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObjectToString 85969 86125 +0.2% 1.00x(?)
ClassArrayGetter 13 13 +0.0% 1.00x
Histogram 284 284 +0.0% 1.00x
DictionaryBridge 3071 3059 -0.4% 1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 5328 5331 +0.1% 1.00x(?)
ObjectiveCBridgeStubFromNSDateRef 3580 3581 +0.0% 1.00x(?)
MonteCarloPi 44872 44863 -0.0% 1.00x(?)
StringWithCString 151053 151041 -0.0% 1.00x(?)
SortLettersInPlace 1061 1060 -0.1% 1.00x(?)
ArrayAppendToFromGeneric 597 597 +0.0% 1.00x
PopFrontArray 1117 1115 -0.2% 1.00x(?)
ArrayOfGenericPOD 219 219 +0.0% 1.00x
Dictionary3OfObjects 919 920 +0.1% 1.00x(?)
MapReduceLazyCollectionShort 63 63 +0.0% 1.00x
StringHasPrefix 606 606 +0.0% 1.00x
ByteSwap 0 0 +0.0% 1.00x
SuperChars 212182 212446 +0.1% 1.00x(?)
ArrayAppendLazyMap 910 909 -0.1% 1.00x(?)
XorLoop 352 352 +0.0% 1.00x
ObserverClosure 2131 2129 -0.1% 1.00x(?)
AnyHashableWithAClass 64643 64691 +0.1% 1.00x(?)
CharacterLiteralsSmall 804 804 +0.0% 1.00x
ArrayPlusEqualSingleElementCollection 57233 57344 +0.2% 1.00x(?)
ArrayAppendStrings 12057 12050 -0.1% 1.00x(?)
ProtocolDispatch 3030 3030 +0.0% 1.00x
ObjectAllocation 174 174 +0.0% 1.00x
TypeFlood 0 0 +0.0% 1.00x
StringHasSuffixUnicode 60755 60870 +0.2% 1.00x(?)
ArrayLiteral 1411 1406 -0.3% 1.00x(?)
Walsh 319 319 +0.0% 1.00x
StrComplexWalk 3019 3006 -0.4% 1.00x(?)
SetIntersect_OfObjects 1453 1459 +0.4% 1.00x(?)
ArrayOfRef 3864 3860 -0.1% 1.00x(?)
ObserverUnappliedMethod 2606 2610 +0.1% 1.00x(?)
ObjectiveCBridgeStubDateMutation 272 272 +0.0% 1.00x
NSError 356 355 -0.3% 1.00x(?)
DictionaryOfObjects 2464 2466 +0.1% 1.00x(?)
PopFrontArrayGeneric 1119 1116 -0.3% 1.00x(?)
ArrayAppendReserved 739 739 +0.0% 1.00x
ObjectiveCBridgeStubToNSStringRef 110 110 +0.0% 1.00x
ArrayAppendFromGeneric 597 597 +0.0% 1.00x
ArrayPlusEqualArrayOfInt 597 597 +0.0% 1.00x
MapReduceShort 2090 2096 +0.3% 1.00x(?)
ArrayAppendUTF16 47746 47700 -0.1% 1.00x(?)
DictionaryLiteral 1474 1477 +0.2% 1.00x(?)
OpenClose 48 48 +0.0% 1.00x
DictionaryRemoveOfObjects 21404 21424 +0.1% 1.00x(?)
UTF8Decode 280 280 +0.0% 1.00x
MapReduceLazySequence 47 47 +0.0% 1.00x
SetIsSubsetOf 247 247 +0.0% 1.00x
NopDeinit 21372 21362 -0.1% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObject 66534 66433 -0.1% 1.00x(?)
SetIntersect 344 343 -0.3% 1.00x(?)
MapReduceClassShort 4823 4818 -0.1% 1.00x(?)
RGBHistogramOfObjects 22207 22234 +0.1% 1.00x(?)
StringBuilder 1405 1405 +0.0% 1.00x
ArrayInClass 61 61 +0.0% 1.00x
ArrayOfGenericRef 3940 3931 -0.2% 1.00x(?)
StringHasSuffix 788 789 +0.1% 1.00x(?)
Sim2DArray 276 276 +0.0% 1.00x
ArrayAppendRepeatCol 756 756 +0.0% 1.00x
MapReduceShortString 20 20 +0.0% 1.00x
MonteCarloE 10453 10424 -0.3% 1.00x(?)
ArrayAppendToGeneric 597 597 +0.0% 1.00x
HashTest 1830 1832 +0.1% 1.00x(?)
SetIsSubsetOf_OfObjects 309 309 +0.0% 1.00x
ArrayAppend 983 982 -0.1% 1.00x(?)
LinkedList 7254 7254 +0.0% 1.00x
MapReduceAnyCollection 343 343 +0.0% 1.00x
ReversedBidirectional 49267 49025 -0.5% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced 4342 4352 +0.2% 1.00x(?)
ArrayAppendSequence 976 977 +0.1% 1.00x(?)
ArrayAppendArrayOfInt 598 597 -0.2% 1.00x(?)
ArrayOfPOD 165 165 +0.0% 1.00x
SetUnion 2069 2066 -0.1% 1.00x(?)
MapReduceLazyCollection 89 89 +0.0% 1.00x
ReversedArray 49 49 +0.0% 1.00x
BitCount 1 1 +0.0% 1.00x
AngryPhonebook 3242 3247 +0.1% 1.00x(?)
SevenBoom 1485 1483 -0.1% 1.00x(?)
StringWalk 5834 5834 +0.0% 1.00x
ArrayValueProp 6 6 +0.0% 1.00x
MapReduceClass 3155 3146 -0.3% 1.00x(?)
GlobalClass 0 0 +0.0% 1.00x
Memset 234 234 +0.0% 1.00x
Dictionary2OfObjects 3628 3622 -0.2% 1.00x(?)
ArrayValueProp4 6 6 +0.0% 1.00x
TwoSum 1363 1369 +0.4% 1.00x(?)
ArrayValueProp2 6 6 +0.0% 1.00x
ArrayValueProp3 6 6 +0.0% 1.00x
ObserverPartiallyAppliedMethod 3710 3708 -0.1% 1.00x(?)
ObjectiveCBridgeToNSString 1291 1303 +0.9% 0.99x(?)
RecursiveOwnedParameter 2068 2080 +0.6% 0.99x
DictionarySwap 419 422 +0.7% 0.99x
ArrayPlusEqualFiveElementCollection 60008 60571 +0.9% 0.99x(?)
StaticArray 127 128 +0.8% 0.99x(?)
SortSortedStrings 838 847 +1.1% 0.99x
ObjectiveCBridgeStubToNSDateRef 3359 3409 +1.5% 0.99x(?)
Hanoi 3357 3385 +0.8% 0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 95963 96870 +0.9% 0.99x(?)
Dictionary 764 769 +0.7% 0.99x(?)
ObjectiveCBridgeStubToArrayOfNSString 31524 31744 +0.7% 0.99x(?)
SetUnion_OfObjects 6141 6230 +1.4% 0.99x(?)
RC4 156 157 +0.6% 0.99x
RGBHistogram 2229 2243 +0.6% 0.99x(?)
Chars 632 641 +1.4% 0.99x
ObserverForwarderStruct 915 921 +0.7% 0.99x(?)
SortStrings 1664 1693 +1.7% 0.98x
ErrorHandling 3126 3201 +2.4% 0.98x(?)
PopFrontUnsafePointer 9102 9271 +1.9% 0.98x(?)
IterateData 2616 2686 +2.7% 0.97x
ObjectiveCBridgeStubFromNSString 896 930 +3.8% 0.96x
PolymorphicCalls 21 22 +4.8% 0.95x
**Unoptimized (Onone)**
Regression (3)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
ReversedArray 475 522 +9.9% 0.91x
BitCount 102 112 +9.8% 0.91x
ObjectiveCBridgeStubDateMutation 485 515 +6.2% 0.94x
Improvement (5)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
StringHasSuffix 1764 1665 -5.6% 1.06x
ObjectiveCBridgeStubDateAccess 1026 972 -5.3% 1.06x
ArrayAppendReserved 3634 3411 -6.1% 1.07x
PopFrontUnsafePointer 179609 161853 -9.9% 1.11x
StringHasPrefix 1722 1515 -12.0% 1.14x
No Changes (164)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
Dictionary3OfObjects 2228 2131 -4.3% 1.05x
StrToInt 5443 5187 -4.7% 1.05x
SortStrings 2627 2524 -3.9% 1.04x
Calculator 1085 1048 -3.4% 1.04x
ObjectiveCBridgeStubFromNSDate 4072 3927 -3.6% 1.04x
ObjectiveCBridgeStubFromNSStringRef 207 201 -2.9% 1.03x
DictionarySwapOfObjects 20281 19643 -3.1% 1.03x
ObjectiveCBridgeToNSSet 38957 37832 -2.9% 1.03x(?)
StringHasPrefixUnicode 16106 15632 -2.9% 1.03x(?)
SetExclusiveOr_OfObjects 39333 38594 -1.9% 1.02x
ArrayAppendLatin1 120164 118265 -1.6% 1.02x(?)
ArrayAppendGenericStructs 1383 1356 -1.9% 1.02x
ArrayAppend 3785 3728 -1.5% 1.02x
ObjectiveCBridgeStubNSDataAppend 2704 2656 -1.8% 1.02x(?)
ClassArrayGetter 1272 1263 -0.7% 1.01x(?)
Histogram 10195 10139 -0.6% 1.01x(?)
ObjectiveCBridgeFromNSStringForced 2711 2678 -1.2% 1.01x(?)
ArrayAppendASCII 97926 97297 -0.6% 1.01x(?)
ArrayAppendOptionals 1376 1363 -0.9% 1.01x
SortSortedStrings 1277 1262 -1.2% 1.01x
CharacterLiteralsLarge 14652 14476 -1.2% 1.01x
Dictionary3 1420 1412 -0.6% 1.01x
SetIntersect_OfObjects 11949 11798 -1.3% 1.01x
ObserverUnappliedMethod 8992 8946 -0.5% 1.01x(?)
ObjectiveCBridgeStubURLAppendPathRef 231382 229262 -0.9% 1.01x(?)
ObjectiveCBridgeToNSArray 32231 31914 -1.0% 1.01x(?)
NSError 703 698 -0.7% 1.01x(?)
DictionaryOfObjects 4763 4706 -1.2% 1.01x(?)
MapReduceShort 58705 58016 -1.2% 1.01x(?)
ArrayAppendUTF16 118362 117269 -0.9% 1.01x(?)
DictionaryLiteral 16638 16418 -1.3% 1.01x(?)
ObjectiveCBridgeStubURLAppendPath 230694 227994 -1.2% 1.01x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 101119 99916 -1.2% 1.01x(?)
ObjectiveCBridgeStubToArrayOfNSString 32232 31876 -1.1% 1.01x(?)
ObjectiveCBridgeFromNSArrayAnyObject 69803 69045 -1.1% 1.01x(?)
ObjectiveCBridgeStubDataAppend 3595 3556 -1.1% 1.01x(?)
MapReduceClassShort 61429 60751 -1.1% 1.01x(?)
SetExclusiveOr 21957 21836 -0.6% 1.01x
ArrayAppendRepeatCol 220453 217242 -1.5% 1.01x
ObjectiveCBridgeToNSDictionary 61999 61408 -0.9% 1.01x(?)
SetUnion_OfObjects 27967 27719 -0.9% 1.01x
RGBHistogramOfObjects 83561 82978 -0.7% 1.01x
ArrayLiteral 1618 1605 -0.8% 1.01x(?)
MapReduceClass 49433 49186 -0.5% 1.01x(?)
Dictionary2OfObjects 6191 6120 -1.1% 1.01x(?)
ArraySubscript 5885 5914 +0.5% 1.00x(?)
ObjectiveCBridgeToNSString 1329 1330 +0.1% 1.00x(?)
MonteCarloPi 53579 53561 -0.0% 1.00x(?)
StackPromo 133384 133735 +0.3% 1.00x(?)
RecursiveOwnedParameter 10897 10898 +0.0% 1.00x(?)
Integrate 378 379 +0.3% 1.00x
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 165821 165755 -0.0% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 88230 88586 +0.4% 1.00x(?)
Array2D 869474 870856 +0.2% 1.00x
DictionaryBridge 3176 3181 +0.2% 1.00x(?)
ObjectiveCBridgeStubFromNSDateRef 3957 3940 -0.4% 1.00x
ArrayOfGenericPOD 3064 3064 +0.0% 1.00x
StringWithCString 149595 149669 +0.1% 1.00x(?)
Prims 13105 13161 +0.4% 1.00x(?)
SortLettersInPlace 2689 2688 -0.0% 1.00x(?)
DictionarySwap 6261 6247 -0.2% 1.00x
ReversedDictionary 32277 32304 +0.1% 1.00x(?)
ArrayAppendToFromGeneric 714 714 +0.0% 1.00x
MapReduceString 2584 2586 +0.1% 1.00x(?)
RangeAssignment 6977 6967 -0.1% 1.00x(?)
MapReduceLazyCollectionShort 48647 48487 -0.3% 1.00x(?)
ByteSwap 10 10 +0.0% 1.00x
ArrayAppendLazyMap 271177 271311 +0.1% 1.00x(?)
ArrayPlusEqualFiveElementCollection 554110 552556 -0.3% 1.00x(?)
XorLoop 26778 26777 -0.0% 1.00x(?)
ObserverClosure 7216 7200 -0.2% 1.00x(?)
CharacterLiteralsSmall 1027 1027 +0.0% 1.00x
ObjectiveCBridgeStubToNSString 1557 1559 +0.1% 1.00x(?)
ArrayAppendStrings 11792 11814 +0.2% 1.00x(?)
Join 1484 1489 +0.3% 1.00x(?)
StaticArray 3630 3643 +0.4% 1.00x
ObjectAllocation 632 630 -0.3% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObject 73466 73162 -0.4% 1.00x(?)
ProtocolDispatch2 423 424 +0.2% 1.00x
Walsh 16347 16323 -0.1% 1.00x(?)
StrComplexWalk 8618 8648 +0.3% 1.00x(?)
ErrorHandling 4070 4083 +0.3% 1.00x(?)
ArrayOfRef 9206 9195 -0.1% 1.00x(?)
ArrayPlusEqualArrayOfInt 714 714 +0.0% 1.00x
ObjectiveCBridgeStubToNSDateRef 3358 3351 -0.2% 1.00x(?)
PopFrontArrayGeneric 9580 9587 +0.1% 1.00x(?)
StringEqualPointerComparison 9724 9712 -0.1% 1.00x(?)
PolymorphicCalls 764 764 +0.0% 1.00x
RC4 11465 11457 -0.1% 1.00x(?)
ObjectiveCBridgeStubToNSStringRef 147 147 +0.0% 1.00x
ArrayAppendFromGeneric 717 716 -0.1% 1.00x(?)
MapReduce 44540 44491 -0.1% 1.00x(?)
MapReduceSequence 47787 47822 +0.1% 1.00x(?)
IterateData 10518 10553 +0.3% 1.00x
Hanoi 19245 19202 -0.2% 1.00x(?)
OpenClose 429 429 +0.0% 1.00x
DictionaryRemoveOfObjects 49858 49834 -0.1% 1.00x(?)
UTF8Decode 46067 46039 -0.1% 1.00x(?)
MapReduceLazySequence 29422 29404 -0.1% 1.00x(?)
171 7618727 7639636 +0.3% 1.00x
SetIsSubsetOf 2083 2081 -0.1% 1.00x
Dictionary 1883 1887 +0.2% 1.00x(?)
SetIntersect 12262 12257 -0.0% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString 105200 105374 +0.2% 1.00x(?)
ObjectiveCBridgeStubNSDateRefAccess 1189 1185 -0.3% 1.00x
ArrayInClass 5311 5311 +0.0% 1.00x
ArrayOfGenericRef 10186 10177 -0.1% 1.00x(?)
ObjectiveCBridgeFromNSString 4093 4090 -0.1% 1.00x(?)
Phonebook 20958 20875 -0.4% 1.00x
Sim2DArray 23253 23255 +0.0% 1.00x(?)
MapReduceShortString 280 281 +0.4% 1.00x(?)
MonteCarloE 109654 109782 +0.1% 1.00x(?)
ReversedBidirectional 134803 135022 +0.2% 1.00x(?)
StringHasSuffixUnicode 63454 63601 +0.2% 1.00x(?)
ArrayAppendToGeneric 717 716 -0.1% 1.00x(?)
HashTest 6243 6234 -0.1% 1.00x(?)
SetIsSubsetOf_OfObjects 1921 1916 -0.3% 1.00x
DictionaryRemove 17988 17960 -0.2% 1.00x(?)
LinkedList 27833 27839 +0.0% 1.00x(?)
MapReduceAnyCollection 44524 44514 -0.0% 1.00x(?)
NSStringConversion 1309 1313 +0.3% 1.00x(?)
MapReduceLazyCollection 38511 38379 -0.3% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced 6716 6740 +0.4% 1.00x(?)
ArrayAppendSequence 72064 72070 +0.0% 1.00x(?)
ArrayAppendArrayOfInt 713 713 +0.0% 1.00x
SetUnion 12021 11972 -0.4% 1.00x(?)
Chars 7442 7439 -0.0% 1.00x(?)
RGBHistogram 34868 34947 +0.2% 1.00x(?)
ObserverForwarderStruct 5212 5214 +0.0% 1.00x(?)
DeadArray 128064 128211 +0.1% 1.00x(?)
AngryPhonebook 3371 3387 +0.5% 1.00x(?)
SevenBoom 1607 1603 -0.2% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 81125 81317 +0.2% 1.00x(?)
ArrayValueProp 3361 3357 -0.1% 1.00x(?)
ObjectiveCBridgeStubFromArrayOfNSString 60783 60669 -0.2% 1.00x(?)
GlobalClass 0 0 +0.0% 1.00x
Memset 33888 33882 -0.0% 1.00x(?)
ArrayValueProp4 3728 3735 +0.2% 1.00x(?)
TwoSum 4982 4977 -0.1% 1.00x(?)
ArrayValueProp2 3914 3910 -0.1% 1.00x(?)
ArrayValueProp3 3786 3776 -0.3% 1.00x
ObserverPartiallyAppliedMethod 8744 8742 -0.0% 1.00x(?)
PopFrontArray 13562 13673 +0.8% 0.99x
ObjectiveCBridgeFromNSDictionaryAnyObject 150469 152158 +1.1% 0.99x(?)
SuperChars 267034 268699 +0.6% 0.99x(?)
StringInterpolation 15093 15280 +1.2% 0.99x(?)
ArrayPlusEqualSingleElementCollection 548279 551690 +0.6% 0.99x(?)
ObjectiveCBridgeStubFromNSString 948 957 +0.9% 0.99x(?)
AnyHashableWithAClass 79646 80154 +0.6% 0.99x
Dictionary2 3799 3824 +0.7% 0.99x(?)
CaptureProp 119363 120340 +0.8% 0.99x
SortStringsUnicode 8466 8516 +0.6% 0.99x
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 73920 74814 +1.2% 0.99x(?)
NSDictionaryCastToSwift 6614 6722 +1.6% 0.98x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 7565 7778 +2.8% 0.97x(?)
TypeFlood 155 159 +2.6% 0.97x(?)
StringBuilder 2894 2973 +2.7% 0.97x(?)
ArrayOfPOD 1832 1892 +3.3% 0.97x
ObjectiveCBridgeFromNSArrayAnyObjectForced 9715 10104 +4.0% 0.96x(?)
ObjectiveCBridgeStubToNSDate 14802 15363 +3.8% 0.96x(?)
StringWalk 21082 21945 +4.1% 0.96x
ObjectiveCBridgeStubNSDateMutationRef 15127 15748 +4.1% 0.96x(?)
ProtocolDispatch 6062 6408 +5.7% 0.95x
NopDeinit 49358 51841 +5.0% 0.95x
**Hardware Overview** Model Name: Mac mini Model Identifier: Macmini7,1 Processor Name: Intel Core i5 Processor Speed: 2.8 GHz Number of Processors: 1 Total Number of Cores: 2 L2 Cache (per Core): 256 KB L3 Cache: 3 MB Memory: 16 GB

@eeckstein
Copy link
Contributor

eeckstein commented Feb 15, 2017

LGTM!
Thanks!

@slavapestov slavapestov merged commit c717f48 into swiftlang:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slavapestov @swift-ci @eeckstein