SILGen: Don’t make class accessors transparent. #6400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test and merge |
eeckstein
force-pushed
the
silgen-fix
branch
from
91429a2 to
9e715c5
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@jckarter, @slavapestov Can you please take a look at that? |
Contributor
|
Build failed |
slavapestov
reviewed
Dec 20, 2016
Contributor
There was a problem hiding this comment.
We want to make tests cross platform where possible. Can you split off a new test if you want to test NSObject subclasses?
Contributor
Author
There was a problem hiding this comment.
I added a #if _runtime(_ObjC)
Because when they are inlined they might access hidden symbols in another module, like the field offset variable. fixes rdar://problem/29707641
eeckstein
force-pushed
the
silgen-fix
branch
from
9e715c5 to
74d979f
Compare
Contributor
Author
|
@swift-ci Please test |
1 similar comment
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Looks good, thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when they are inlined they might access hidden symbols in another module, like the field offset variable.
fixes rdar://problem/29707641
@slavapestov Thanks for your help!