Minor isolation checking fixes #73057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formance() Use the self interface type instead of the declared interface type, to get the right type for tuple conformances and the DistributedActor-as-Actor abstract conformance.
Due to a quirk of the ASTVisitor, we would then visit accessors twice, the first time as part of the PatternBindingDecl inside the TopLevelCodeDecl, and at that point the accessor body has not yet been type checked.
Otherwise, we'll miss captures inside closures inside stored property initializer expressions.
slavapestov
requested review from
hborla,
ktoso,
tshortli and
xedin
as code owners
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #72936. It doesn't yet fix an issue with isolation checking of recursive local functions, so I can't land the assert that prevents looking at captures before they're computed, but this gets us most of the way there.
6.0 PR was already merged: #73024