Request-ify TypeChecker::computeCaptures() #72936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
requestify-compute-captures
branch
from
a609285 to
88baa45
Compare
slavapestov
force-pushed
the
requestify-compute-captures
branch
from
88baa45 to
d8cf028
Compare
slavapestov
force-pushed
the
requestify-compute-captures
branch
from
d8cf028 to
517e1ea
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
requestify-compute-captures
branch
2 times, most recently
from
d453149 to
a1a07d8
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
requestify-compute-captures
branch
from
a1a07d8 to
b778492
Compare
Contributor
Author
|
@swift-ci Please smoke test |
We now compute captures of functions and default arguments lazily, instead of as a side effect of primary file checking. Captures of closures are computed as part of the enclosing context, not lazily, because the type checking of a single closure body is not lazy. This fixes a specific issue with the `-experimental-skip-*` flags, where functions declared after a top-level `guard` statement are considered to have local captures, but nothing was forcing these captures to be computed. Fixes rdar://problem/125981663.
slavapestov
force-pushed
the
requestify-compute-captures
branch
from
b778492 to
55ff73f
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now compute captures of functions, closures and default arguments lazily, instead of as a side effect of primary file checking.
This fixes a specific issue with the
-experimental-skip-*flags, where functions declared after a top-levelguardstatement are considered to have local captures, but nothing was forcing these captures to be computed.Fixes rdar://problem/125981663.