[Dependency Scanning] Collect emitted diagnostics per-scan-query #71907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
ScannerDiagsPerQuery
branch
from
9d3d48a to
315b476
Compare
artemcm
force-pushed
the
ScannerDiagsPerQuery
branch
from
315b476 to
acd29b8
Compare
|
swiftlang/swift-driver#1552 |
2 similar comments
|
swiftlang/swift-driver#1552 |
|
swiftlang/swift-driver#1552 |
|
swiftlang/swift-driver#1552 |
artemcm
force-pushed
the
ScannerDiagsPerQuery
branch
from
acd29b8 to
d2a8e32
Compare
|
swiftlang/swift-driver#1552 |
cachemeifyoucan
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds APIs to libSwiftScan that report diagnostics per each scanning query as a part of the produced
swiftscan_dependency_graph_torswiftscan_import_set_t.Clients then no longer query the scanner's overall collected diagnostics. The scanner, for now, continues maintaining a shared Diagnostic Consumer in the
DependencyScanningTool, which we've guarded with manual isolation to try and prevent concurrency issues:#71792
Nevertheless, the approach of a shared diagnostic consumer by a
DependencyScanningToolis broadly incorrect and has been giving us issues in contexts where the same tool is shared across many concurrently-executing scanning queries some of which may emit diagnostics.API and code-paths added here are exercised and tested in: swiftlang/swift-driver#1552