[Dependency Scanning] Guard access to shared state of the DependencyScannerDiagnosticCollectingConsumer
#71792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
cachemeifyoucan
approved these changes
Feb 21, 2024
Contributor
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
convertDiagnosticInfo seems an unused declaration that can be removed.
Would be good to write a test. I added swift-scan-test tool that can be used to call into libSwiftScan APIs.
…ScannerDiagnosticCollectingConsumer` Resolves rdar://123344065
artemcm
force-pushed
the
DepScanDiagConsumerIsolate
branch
from
c87a4d7 to
5c4bbc1
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test Windows platform |
Contributor
Author
|
Longer-term fix landed in #71907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DependencyScanningToolhas oneDependencyScannerDiagnosticCollectingConsumerwhich gets associated with each individual scan query during lifetime of the tool. This isn't a valid use of such diagnostic consumer because the tool may be handling multiple scan queries at any given time, which may all be adding/resetting/querying diagnostics. For now, guard the shared state of the shared consumer as a short-term fix.A follow-up change will refactor the diagnostic consumer to be per-client-scan.
Resolves rdar://123344065