Skip to content

Conversation

@hjyamauchi
Copy link
Contributor

This addresses a review comment at
#69368 (comment)

@compnerd
Copy link
Member

@swift-ci please test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to include a little more context here such which !DI...() node this appears inside of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL

@hjyamauchi hjyamauchi force-pushed the round-trip-debug-types-typealias branch from 7679d70 to 23eefe6 Compare November 17, 2023 02:20
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Windows platform

@hjyamauchi
Copy link
Contributor Author

@swift-ci Please test Windows platform

@compnerd
Copy link
Member

@swift-ci please test Windows platform

@hjyamauchi hjyamauchi enabled auto-merge November 23, 2023 23:31
auto-merge was automatically disabled November 27, 2023 04:38

Base branch was modified

@hjyamauchi hjyamauchi merged commit fdf6b53 into swiftlang:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants