Fix a round trip debug type failure with typealias #69368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking equality of types with existential types removed, recursively remove existential types inside an existential type. Fixes: swiftlang#66554 Cherrypick swiftlang@fda6f9b
Member
|
@swift-ci please test |
slavapestov
approved these changes
Oct 24, 2023
|
|
||
| protocol Protocol<T> { associatedtype T } | ||
| typealias AnyProtocol<T> = any Protocol<T> | ||
| let crash: AnyProtocol<Any?> |
Contributor
There was a problem hiding this comment.
Can you pipe the -emit-ir output to FileCheck and CHECK the mangled type name of "crash"?
Member
There was a problem hiding this comment.
@adrian-prantl this is a cherry-pick to 5.9, I think that doing that on main is a good idea though.
Member
|
@swift-ci please build toolchain Windows platform |
Contributor
Author
adrian-prantl
approved these changes
Nov 7, 2023
Contributor
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
Code change LGTM, but please update the test.
Contributor
Author
|
Yeah, will do. |
Contributor
Author
|
@adrian-prantl #69935 updates the test |
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Nov 17, 2023
This addresses a review comment at swiftlang#69368 (comment)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking equality of types with existential types removed, recursively remove existential types inside an existential type.
Fixes: #66554
Cherrypick fda6f9b