Skip to content

[DNM] Verify Wasm build script #69239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DNM] Verify Wasm build script #69239

wants to merge 3 commits into from

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 18, 2023 •
edited
Loading

No description provided.

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 18, 2023

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun kateinoigakukun force-pushed the yt/wasm-stdlib-product-pr-verify branch 2 times, most recently from 51340cd to dbc5dba Compare October 18, 2023 01:36
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 18, 2023

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
[wasm][build] Build and test stdlib for WebAssembly
0908dc2 
This patch adds a new build products to build and test the Swift stdlib
for WebAssembly.
This adds WebAssembly specific stdlib product instead of adding the new
target in `stdlib-deployment-targets` because unlike darwin platforms
Wasm target has quite different stdlib configuration from host target
and there is no way to specify different stdlib configuration for each
target in `stdlib-deployment-targets` for now.

This patch adds 1 new dependency `wasi-libc` and 3 new build products:
1. `WASILibc` - wasi-libc is a libc implementation for WebAssembly
   System Interface (WASI). This product is required to build the
   compiler runtimes and Swift stdlib.
2. `WasmLLVMRuntimeLibs` - This product builds `./runtimes` directory
   in llvm-project, which contains compiler-rt, libcxx and libcxxabi.
   This product is required to build Swift stdlib.
3. `WasmStdlib` - This product builds standalone Swift stdlib for
   WebAssembly. (Similar to `MinimalStdlib` product, but configured for
   WebAssembly target)
@kateinoigakukun
DO NOT MERGE: Workaround for bad codegen
c11e4b9
@kateinoigakukun
[wasm][test] Disable a test that depends on swifttailcc
6b73f59
@kateinoigakukun kateinoigakukun force-pushed the yt/wasm-stdlib-product-pr-verify branch from dbc5dba to 6b73f59 Compare October 18, 2023 03:33
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 18, 2023

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 18, 2023

Okay, it's green! https://ci.swift.org/job/swift-PR-Linux-preset/91/console

-- Testing: 864 tests, 36 workers --
Testing: lit.py: /home/build-user/swift/test/lit.cfg:2859: note: Available features: CMAKE_GENERATOR=Ninja, CODEGENERATOR=AArch64, CODEGENERATOR=ARM, CODEGENERATOR=WebAssembly, CODEGENERATOR=X86, CPU=wasm32, OS=wasi, PTRSIZE=32, SWIFT_VERSION=4, VENDOR=unknown, asserts, autolink-extract, concurrency, concurrency_runtime, cplusplus_driver, crash-recovery, hosttools_mode, libxml2, no_asan, no_lto, nonexecutable_test, optimized_stdlib, optimized_stdlib_wasm32, reflection, shell, single_threaded_concurrency, string_processing, swift_in_compiler, swift_stdlib_no_asserts, swift_swift_parser, threading_none
 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

Testing Time: 3.73s
  Unsupported      : 533
  Passed           : 328
  Expectedly Failed:   3

@kateinoigakukun kateinoigakukun deleted the yt/wasm-stdlib-product-pr-verify branch October 18, 2023 05:36
@kateinoigakukun kateinoigakukun mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal will be requested when the pull request is marked ready for review shahmishal is a code owner

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde will be requested when the pull request is marked ready for review etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple will be requested when the pull request is marked ready for review justice-adams-apple is a code owner

@edymtt edymtt Awaiting requested review from edymtt edymtt will be requested when the pull request is marked ready for review edymtt is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall will be requested when the pull request is marked ready for review rjmccall is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kateinoigakukun