[wasm][build] Build stdlib and test IRGen for WebAssembly #69101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
added
build-script
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
b8630f1 to
e8a8f14
Compare
kateinoigakukun
changed the title
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
preset= buildbot_linux_crosscompile_wasm |
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
e8a8f14 to
2625f83
Compare
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
preset=buildbot_linux_crosscompile_wasm |
Member
Author
|
The stdlib compilation crash will be resolved after rebranch will be merged |
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
2625f83 to
6b391e4
Compare
Member
Author
|
I confirmed it passes with the llvm fix included in the rebranch #69239 |
Member
Author
|
preset=buildbot_linux_crosscompile_wasm |
shahmishal
reviewed
Oct 23, 2023
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
6b391e4 to
f8c8dd9
Compare
shahmishal
reviewed
Oct 23, 2023
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
2 times, most recently
from
caa9bf1 to
b022941
Compare
Member
Author
|
preset=buildbot_linux_crosscompile_wasm |
This patch adds a new build products to build and test the Swift stdlib for WebAssembly. This adds WebAssembly specific stdlib product instead of adding the new target in `stdlib-deployment-targets` because unlike darwin platforms Wasm target has quite different stdlib configuration from host target and there is no way to specify different stdlib configuration for each target in `stdlib-deployment-targets` for now. This patch adds 1 new dependency `wasi-libc` and 3 new build products: 1. `WASILibc` - wasi-libc is a libc implementation for WebAssembly System Interface (WASI). This product is required to build the compiler runtimes and Swift stdlib. 2. `WasmLLVMRuntimeLibs` - This product builds `./runtimes` directory in llvm-project, which contains compiler-rt, libcxx and libcxxabi. This product is required to build Swift stdlib. 3. `WasmStdlib` - This product builds standalone Swift stdlib for WebAssembly. (Similar to `MinimalStdlib` product, but configured for WebAssembly target)
Member
Author
|
@swift-ci Please smoke test |
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
b022941 to
641e753
Compare
Member
Author
|
preset=buildbot_linux_crosscompile_wasm |
Member
Author
|
@swift-ci Please smoke test |
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
641e753 to
f3455d8
Compare
Member
Author
|
Added a few test fix commits that are found after rebranch 🩹 |
Member
Author
|
preset=buildbot_linux_crosscompile_wasm |
Member
Author
|
@swift-ci Please smoke test |
stable/20230725 now rejects including builtin headers in modulemap by default to avoid module cycles on non-Apple platforms. Builtin headers are now part of their own `_Builtin_XXX` modules. See: - swiftlang/llvm-project#7618 - https://reviews.llvm.org/D159483 - https://reviews.llvm.org/D159064
To follow up changes in 5f037ef
kateinoigakukun
force-pushed
the
yt/wasm-stdlib-product-pr
branch
from
f3455d8 to
977b74a
Compare
Member
Author
|
preset=buildbot_linux_crosscompile_wasm |
Member
Author
|
@swift-ci Please smoke test |
MaxDesiatov
reviewed
Oct 24, 2023
MaxDesiatov
approved these changes
Oct 24, 2023
Contributor
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
🤩 Super excited to see this, thank you!
shahmishal
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds new build products to build and test the Swift stdlib for WebAssembly.
This adds WebAssembly specific stdlib product instead of adding the new target in
stdlib-deployment-targetsbecause unlike darwin platforms Wasm target has quite different stdlib configuration from host target and there is no way to specify different stdlib configuration for each target instdlib-deployment-targetsfor now.This patch adds 1 new dependency
wasi-libcand 3 new build products:WASILibc- wasi-libc is a libc implementation for WebAssembly System Interface (WASI). This product is required to build the compiler runtimes and Swift stdlib.WasmLLVMRuntimeLibs- This product builds./runtimesdirectory in llvm-project, which contains compiler-rt, libcxx and libcxxabi. This product is required to build Swift stdlib.WasmStdlib- This product builds standalone Swift stdlib for WebAssembly. (Similar toMinimalStdlibproduct, but configured for WebAssembly target)Currently
WasmStdlibruns test suite undertest/IRGento verify the semi-target specific code in IRGen works and the generated IR can be processed by LLVM WebAssembly backend. Rest of test suites including executable tests are now skipped, but will be enabled after we set up a Wasm runtime in the CI infrastructure and calling convention mismatch issues will be resolved.Resolves rdar://116007434 and rdar://116523979.