Ensure #if $MoveOnly feature guard evaluates to true.
#64560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
kavon
force-pushed
the
revive-noncopyable-job
branch
from
d6ac073 to
7f641f3
Compare
Member
Author
|
@swift-ci please smoke test |
kavon
force-pushed
the
revive-noncopyable-job
branch
from
7f641f3 to
536ce51
Compare
kavon
changed the title
#if $MoveOnly feature guard evaluates to true.
Member
Author
|
@swift-ci please test |
ktoso
reviewed
Mar 24, 2023
ktoso
reviewed
Mar 24, 2023
I enabled move-only types by default, but I didn't realize that the `Feature::MoveOnly` needs to graduate into a `LANGUAGE_FEATURE` so that `EvaluateIfConfigCondition` will recognize `$MoveOnly` as being true. fixes rdar://107050387
kavon
force-pushed
the
revive-noncopyable-job
branch
2 times, most recently
from
0f37c53 to
86f6941
Compare
This reverts commit abe377c. Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
kavon
force-pushed
the
revive-noncopyable-job
branch
from
86f6941 to
363448a
Compare
Member
Author
|
@swift-ci please smoke test and merge |
Contributor
|
This was missing a 5.9 cherry pick; #64666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle issue with feature flags after I enabled move-only types by default. Turns out that the
$MoveOnlyfeature guard wasn't always evaluating to true when the-enable-experimental-move-onlyisn't provided. This change now ensures that's the case so that public noncopyable types compiled in different modules are picked up correctly.There's a separate sort of oddity where
hasFeature(Feature::Something)still evaluates to false, whereSomethingis an always-on feature. That will be addressed in a separate PR here: #64602resolves rdar://107050387