enable standard language features in LangOptions #64602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci smoke test |
Member
Author
|
@swift-ci please test |
1 similar comment
Member
Author
|
@swift-ci please test |
kavon
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
kavon
requested review from
DougGregor and
zoecarver
and removed request for
hborla,
slavapestov,
tshortli and
xedin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kind of odd how features that are unconditionally enabled, like
Feature::Actorsis not actually satisfyingLangOptions.hasFeature(Feature::Actors). This wasn't causing a problem elsewhere when parsing the feature in swiftinterface files becauseEvaluateIfConfigCondition::visitUnresolvedDeclRefExprhas its own switch over the features (rather than asking if it's enabled). Also, most of the time when someone enables a feature permanently, it's expected that allhasFeaturequeries are removed because "it's now always on". Now we actually make sure the feature is always on.