Skip to content

guard assume on executor API against task-to-thread runtimes #64211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2023
Merged

guard assume on executor API against task-to-thread runtimes #64211

merged 3 commits into from
Mar 9, 2023

Conversation

@kavon
Copy link
Member

@kavon kavon commented Mar 8, 2023 •
edited
Loading

without these guards, building for minimal runtimes will fail with errors about global actors, which aren't permitted when compiling with the task-to-thread concurrency model.

rdar://106434422

@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

@swift-ci please smoke test

ktoso
ktoso approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

#64202
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

linux failure seems to be randomly curl failing:

FAIL: Testing swift-docc failed
[...]
hudson.AbortException: script returned exit code 1

@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

@swift-ci smoke test linux platform

@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

#64202
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

@swift-ci please smoke test

@kavon kavon requested a review from etcwilde March 8, 2023 22:16
@kavon kavon requested a review from rokhinip March 8, 2023 22:56
@kavon
Copy link
Member Author

kavon commented Mar 8, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kavon
Copy link
Member Author

kavon commented Mar 9, 2023

@swift-ci smoke test

@al45tair
Copy link
Contributor

al45tair commented Mar 9, 2023

#64234
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@al45tair
Copy link
Contributor

al45tair commented Mar 9, 2023

#64234
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@al45tair al45tair mentioned this pull request Mar 9, 2023
Merged
@al45tair
Copy link
Contributor

al45tair commented Mar 9, 2023

I'm not convinced that mentioning my PR actually did anything different here. I don't see the --swift-enable-backtracing 0 that I'd expect to see in the build-script step at the top.

rokhinip
rokhinip approved these changes Mar 9, 2023
View reviewed changes
@kavon kavon merged commit 4c65c33 into swiftlang:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktoso ktoso ktoso approved these changes

@rokhinip rokhinip rokhinip approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kavon @al45tair @ktoso @rokhinip