[Remote Mirror] Only build under the control of SWIFT_BUILD_REMOTE_MIRROR #64202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RROR. Remote Mirror should be building under the control of its own flag, not trying to hijack the standard library build flags. If presets want (or do not want) remote mirror, they should set its build flag appropriately. (The default is to build it, so mostly this means some things should be disabling it. I'd already done the work for that as part of previous PRs, but apparently stopped short of completely dissociating it from `SWIFT_BUILD_STDLIB`, which was an error as it means that the minimal preset and things based on it are currently slightly broken.) rdar://106415217
Contributor
Author
|
@swift-ci Please test |
Member
|
IIRC the current state was emergent behaviour as there were dependencies on it for some of the reflection bits and the standard library build needed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote Mirror should be building under the control of its own flag, not trying to hijack the standard library build flags. If presets want (or do not want) remote mirror, they should set its build flag appropriately.
(The default is to build it, so mostly this means some things should be disabling it. I'd already done the work for that as part of previous PRs, but apparently stopped short of completely dissociating it from
SWIFT_BUILD_STDLIB, which was an error as it means that the minimal preset and things based on it are currently slightly broken.)rdar://106415217