Skip to content

Disable the _StringProcessing import in the Observation module #64185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

Disable the _StringProcessing import in the Observation module #64185

merged 1 commit into from
Mar 7, 2023

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented Mar 7, 2023

Fixes rdar://106374161

@DougGregor
Copy link
Member Author

DougGregor commented Mar 7, 2023

@swift-ci please smoke test and merge

phausler
phausler approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct to me

@Azoy
Copy link
Contributor

Azoy commented Mar 7, 2023 •
edited
Loading

add_swift_target_library should be doing this automatically. If it's not then something changed to enable it.
Here: https://github.com/apple/swift/blob/92581020ecc5dd0ec20b35c573d7914b8a5224e6/stdlib/cmake/modules/AddSwiftStdlib.cmake#L1821

Edit: We should probably not conditionalize the disabling of the string processing import in the cmake function now and just unconditionally disable it. #64187

@Azoy
Copy link
Contributor

Azoy commented Mar 7, 2023

I just otool -L libswiftObservation.dylib and string processing is not a listed link dependency.

@swift-ci swift-ci merged commit d16cc6d into swiftlang:main Mar 7, 2023
@DougGregor DougGregor deleted the observation-without-string-processing branch March 7, 2023 23:53
@DougGregor
Copy link
Member Author

DougGregor commented Mar 7, 2023

I'm fine with doing this all the time for add_swift_target_library. We can't do it for host libraries, because those need to be able to build with compilers that predate this flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phausler phausler phausler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DougGregor @Azoy @phausler @swift-ci